Skip to content

Conversation

jebentier
Copy link
Collaborator

Add Deep merge support

Summary of Changes

This PR is adding the usage of active support's deep_merge when combining context layers together so that sub groupings of context can be updated by various layers.

@jebentier jebentier force-pushed the 1907/no_jira_passion_deep_merge_context branch from eca6ac9 to 9044ee0 Compare July 2, 2019 18:14
@jebentier jebentier requested a review from alecjacobs5401 July 3, 2019 14:31
Copy link

@alecjacobs5401 alecjacobs5401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like activesupport is only defined in the development bundler group.

Since we're now depending on it for the code, it should probably be defined as a dependenct in the gemspec

@jebentier
Copy link
Collaborator Author

Good call. Thanks for pointing that out. I've gone ahead and added it as a runtime dependency within the gemspec.

@jebentier jebentier requested a review from alecjacobs5401 July 3, 2019 21:04
@jebentier jebentier merged commit 9fd8da4 into master Jul 3, 2019
@jebentier jebentier deleted the 1907/no_jira_passion_deep_merge_context branch July 3, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants