Skip to content

Conversation

jebentier
Copy link
Contributor

@jebentier jebentier commented Oct 9, 2020

Exposes a new method restart_after_fork that operates as start used to.

@jebentier jebentier force-pushed the TECH-4861_add_restart_after_fork_method branch 3 times, most recently from 417836b to 2200193 Compare October 11, 2020 09:11
@jebentier jebentier requested a review from nburwell October 11, 2020 09:12
@jebentier jebentier self-assigned this Oct 11, 2020
Copy link
Contributor

@nburwell nburwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

expect(monitor).to receive(:start_internal).with(true).and_return(true)
end

after {FileUtils.rm_f(SETTINGS_PATH) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing whitespace after {

@jebentier jebentier merged commit 42a88fc into master Oct 12, 2020
@jebentier jebentier deleted the TECH-4861_add_restart_after_fork_method branch October 12, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants