Skip to content

Conversation

@giggsey
Copy link
Contributor

@giggsey giggsey commented Jan 6, 2022

Closes #15

@giggsey
Copy link
Contributor Author

giggsey commented Jan 6, 2022

@IonBazan I haven't done the GitHub Formatter yet, as I'm unsure how it'll render urls.

For the markdown ones, I've put them as the package name rather than a new column

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #16 (347c7ee) into main (52b0f49) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main       #16   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       176       197   +21     
===========================================
  Files             19        19           
  Lines            473       503   +30     
===========================================
+ Hits             473       503   +30     
Impacted Files Coverage Δ
src/Formatter/AbstractFormatter.php 100.00% <100.00%> (ø)
src/Formatter/JsonFormatter.php 100.00% <100.00%> (ø)
src/Formatter/MarkdownListFormatter.php 100.00% <100.00%> (ø)
src/Formatter/MarkdownTableFormatter.php 100.00% <100.00%> (ø)
src/Url/BitBucketGenerator.php 100.00% <100.00%> (ø)
src/Url/GithubGenerator.php 100.00% <100.00%> (ø)
src/Url/GitlabGenerator.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b0f49...347c7ee. Read the comment docs.

@IonBazan
Copy link
Owner

IonBazan commented Jan 6, 2022

Looks nice! Just need to add some more coverage and it will be good to go.

For the GitHub formatter, I think it would not look good with the links as they are not clickable so let's leave it as is.

Copy link
Owner

@IonBazan IonBazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@IonBazan IonBazan merged commit 319f10b into IonBazan:main Jan 6, 2022
@IonBazan
Copy link
Owner

IonBazan commented Jan 6, 2022

Thanks @giggsey! Your changes were released as https://github.com/IonBazan/composer-diff/releases/tag/v1.6.0

@giggsey giggsey deleted the project-links branch January 6, 2022 11:10
@giggsey
Copy link
Contributor Author

giggsey commented Jan 6, 2022

Thanks for the prompt reviews

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link to project?

2 participants