Skip to content

Conversation

@trakos
Copy link
Contributor

@trakos trakos commented Jun 21, 2021

Hey 🙂

we've noticed that commit changes don't show up in composer diff. If someone stays on the same branch version, but updates the package, it won't show up in diff. I think it's worth showing all differences, so I propose a simple change to show it.

Method getPrettyVersion I've used seems to be added quite early to composer, before stable 1.0, so it should be fine? composer/composer@99dab8a

Before:

image

After:

image

Also, I've updated the test composer.jsons to have roave/security-advisory, since that's the package I've happened to notice that with. I guess it's a good example, because it doesn't have any versions, yet is quite popular: https://packagist.org/packages/roave/security-advisories . I've run:

cd tests/fixtures/base
composer require 'roave/security-advisories:dev-master#ac36586'
cd ../target
composer require 'roave/security-advisories:dev-master#3c97c13'

Thanks!

@trakos trakos force-pushed the show-dev-commit-changes branch from 7921948 to be74acb Compare June 21, 2021 22:41
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #9 (be74acb) into main (a968372) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main        #9   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       162       162           
===========================================
  Files             19        19           
  Lines            430       430           
===========================================
  Hits             430       430           
Impacted Files Coverage Δ
src/PackageDiff.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a968372...be74acb. Read the comment docs.

@IonBazan
Copy link
Owner

Looks good, thanks!

@IonBazan IonBazan merged commit dd04c55 into IonBazan:main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants