Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Conversation

@manez
Copy link
Member

@manez manez commented Jan 11, 2019

JIRA Ticket: https://jira.duraspace.org/browse/ISLANDORA-2349

What does this Pull Request do?

Two changes to the pull request template:

  1. New text at the top to warn the unwary to not leave all of the default text in place when submitting a pull request. Lots of !!!! and CAPS because it has to be noticeable in the edit screen, not when published.
  2. Expanding the "does this need documentation" text to include examples and cut down on false negatives.

This was discussed at the November 29th Committers call, with a test PR confirmed and merged on Jan 10 2019.

What's new?

A new warning at the top of the PR template and a small change in the body.

Interested parties

@Islandora/7-x-1-x-committers

@bondjimbond bondjimbond merged commit 2e26baf into Islandora:7.x Jan 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants