Skip to content

Conversation

@Issy90
Copy link
Owner

@Issy90 Issy90 commented Oct 11, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • [ ✓] I can confirm that my changes are working as intended

@mandana-g
Copy link

mandana-g commented Oct 15, 2025

Thanks Isra. Your Assignment 1 is approved. Just a couple of notes:

  1. O(n) time and space complexity are both generally considered efficient, especially for problems like this where tracking each element is necessary.
  2. There's a small typo in your explanation of the alternative solution. You wrote “we would need to store anything” but it looks like you meant “we wouldn’t need to store anything.”

Other than that, everything looks great. Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants