Android notifications with images. #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtruong
changed the title
davidtruong
changed the title
dontgitit
reviewed
Jul 25, 2017
| if (picassoClass != null) { | ||
| Picasso.with(mContext).load(imageUrl).into(bigContentView, bigIconId, requestCode, notification); | ||
| } | ||
| } catch (ClassNotFoundException e) { |
Contributor
There was a problem hiding this comment.
is it ok to ask people to rely on that?
Contributor
Author
There was a problem hiding this comment.
Technically this isn't needed since we embed that reference in our SDK export. However I thought it would be good to have it in there just in case that changes in the future.
dontgitit
approved these changes
Jul 25, 2017
Contributor
dontgitit
left a comment
dontgitit
left a comment
There was a problem hiding this comment.
looks like you have a merge conflict now, otherwise lftm
davidtruong
deleted the
feature/ITBL-2245-android-image-push-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.