[MOB-1124] Don't log an error when notification channel name is not set #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayyanchira
approved these changes
Feb 10, 2020
Member
Ayyanchira
left a comment
Ayyanchira
left a comment
There was a problem hiding this comment.
The failure on travis looks like the one of test notification image which is fixed on the other branch. 👍
vbabenkoru
force-pushed
the
bugfix/MOB-1124-no-error-on-no-channel-name
branch
from
8efd99e to
68ea937
Compare
Ayyanchira
approved these changes
Feb 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
=======================================
Coverage 73.37% 73.37%
=======================================
Files 34 34
Lines 1968 1968
Branches 213 213
=======================================
Hits 1444 1444
Misses 382 382
Partials 142 142
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was working but was logging this error message every time:
android.content.res.Resources$NotFoundException: String resource ID #0x0.We should not be trying to get resource ID 0.