[MOB-1713] - Update IterableLogger #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrintInfo method internally uses system level log instead of using IterableLogger. This bypasses the Iterable's config value. The fix: use IterableLogger. It will print only when VERBOSE is set in config.
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 76.08% 76.08%
=======================================
Files 50 50
Lines 2877 2877
Branches 333 333
=======================================
Hits 2189 2189
Misses 480 480
Partials 208 208
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrintInfo method internally uses system level log instead of using IterableLogger. This bypasses the Iterable's config value.
The fix: use IterableLogger. It will print only when VERBOSE is set in config.
Closes #235