Skip to content

Conversation

@vbabenkoru
Copy link
Contributor

@vbabenkoru vbabenkoru commented Jan 12, 2021

🔹 Jira Ticket(s) if any

✏️ Description

The code was checking for the presence of a Firebase database URL, that is not directly necessary for push to work. This PR changes the check to get the FCM sender id, that is actually necessary for push and is a better indicator of FCM being set up correctly.

@vbabenkoru vbabenkoru requested a review from Ayyanchira January 12, 2021 20:54
Check for sender id instead of Firebase database URL
@vbabenkoru vbabenkoru force-pushed the bugfix/MOB-2433-fix-firebase-resource-id branch from 84cdd84 to a88a4d4 Compare January 12, 2021 21:25
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #306 (a88a4d4) into master (dabf649) will increase coverage by 1.91%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   68.51%   70.42%   +1.91%     
==========================================
  Files          60       60              
  Lines        3605     3605              
  Branches      420      421       +1     
==========================================
+ Hits         2470     2539      +69     
+ Misses        894      807      -87     
- Partials      241      259      +18     
Impacted Files Coverage Δ
...va/com/iterable/iterableapi/IterableConstants.java 0.00% <ø> (ø)
...ain/java/com/iterable/iterableapi/IterableApi.java 64.54% <100.00%> (+0.18%) ⬆️
...able/iterableapi/IterablePushRegistrationTask.java 66.10% <100.00%> (+2.16%) ⬆️
...va/com/iterable/iterableapi/IterableApiClient.java 75.32% <0.00%> (+0.65%) ⬆️
...in/java/com/iterable/iterableapi/IterableTask.java 43.33% <0.00%> (+3.33%) ⬆️
.../java/com/iterable/iterableapi/IterableConfig.java 86.95% <0.00%> (+4.34%) ⬆️
.../iterable/iterableapi/OfflineRequestProcessor.java 81.25% <0.00%> (+12.50%) ⬆️
.../com/iterable/iterableapi/IterableTaskStorage.java 23.39% <0.00%> (+23.39%) ⬆️
...terableapi/IterableNetworkConnectivityManager.java 35.29% <0.00%> (+35.29%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac66cca...a88a4d4. Read the comment docs.

@vbabenkoru vbabenkoru merged commit 9eb13e2 into master Jan 13, 2021
@vbabenkoru vbabenkoru deleted the bugfix/MOB-2433-fix-firebase-resource-id branch January 13, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants