Skip to content

[MOB-2680] - Increase timeout for get calls #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2021
Merged

[MOB-2680] - Increase timeout for get calls #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions iterableapi/src/main/java/com/iterable/iterableapi/IterableRequestTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ class IterableRequestTask extends AsyncTask<IterableApiRequest, Void, IterableAp

static String overrideUrl;

static final int DEFAULT_TIMEOUT_MS = 3000; //3 seconds
static final int POST_REQUEST_DEFAULT_TIMEOUT_MS = 3000; //3 seconds
static final int GET_REQUEST_DEFAULT_TIMEOUT_MS = 10000; //10 seconds
static final long RETRY_DELAY_MS = 2000; //2 seconds
static final int MAX_RETRY_COUNT = 5;

Expand Down Expand Up @@ -82,8 +83,8 @@ static IterableApiResponse executeApiRequest(IterableApiRequest iterableApiReque
url = new URL(builder.build().toString());
urlConnection = (HttpURLConnection) url.openConnection();

urlConnection.setReadTimeout(DEFAULT_TIMEOUT_MS);
urlConnection.setConnectTimeout(DEFAULT_TIMEOUT_MS);
urlConnection.setReadTimeout(GET_REQUEST_DEFAULT_TIMEOUT_MS);
urlConnection.setConnectTimeout(GET_REQUEST_DEFAULT_TIMEOUT_MS);

urlConnection.setRequestProperty(IterableConstants.HEADER_API_KEY, iterableApiRequest.apiKey);
urlConnection.setRequestProperty(IterableConstants.HEADER_SDK_PLATFORM, "Android");
Expand All @@ -102,8 +103,8 @@ static IterableApiResponse executeApiRequest(IterableApiRequest iterableApiReque
urlConnection.setDoOutput(true);
urlConnection.setRequestMethod(iterableApiRequest.requestType);

urlConnection.setReadTimeout(DEFAULT_TIMEOUT_MS);
urlConnection.setConnectTimeout(DEFAULT_TIMEOUT_MS);
urlConnection.setReadTimeout(POST_REQUEST_DEFAULT_TIMEOUT_MS);
urlConnection.setConnectTimeout(POST_REQUEST_DEFAULT_TIMEOUT_MS);

urlConnection.setRequestProperty("Accept", "application/json");
urlConnection.setRequestProperty("Content-Type", "application/json");
Expand Down