Skip to content

Conversation

@Ayyanchira
Copy link
Member

🔹 Jira Ticket(s) if any

https://iterable.atlassian.net/browse/MOB-2656

✏️ Description

  1. Allowing dismiss with state loss.

This allows the inapp to be dismissed in background without crashing, after the app is minimized. Dismiss after app background happens in attempt to achieve smooth dismiss animation.

Resolves the github issue - #322

1. Allowing dismiss with state loss.

This allows the inapp to be dismissed in background without crashing, after the app is minimized. Dismiss after app background happens in attempt to achieve smooth dismiss animation.

Resolves the github issue - #322
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #327 (dacb728) into master (423b507) will increase coverage by 0.26%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   70.35%   70.61%   +0.26%     
==========================================
  Files          60       60              
  Lines        3701     3727      +26     
  Branches      430      433       +3     
==========================================
+ Hits         2604     2632      +28     
+ Misses        832      830       -2     
  Partials      265      265              
Impacted Files Coverage Δ
...va/com/iterable/iterableapi/IterableConstants.java 0.00% <ø> (ø)
...ableapi/IterableInAppFragmentHTMLNotification.java 48.90% <0.00%> (ø)
...le/iterableapi/ui/inbox/IterableInboxFragment.java 83.87% <96.15%> (+1.34%) ⬆️
...le/iterableapi/ui/inbox/IterableInboxActivity.java 81.48% <100.00%> (+5.29%) ⬆️
...java/com/iterable/iterableapi/ui/BitmapLoader.java 61.90% <0.00%> (-2.39%) ⬇️
...va/com/iterable/iterableapi/IterableApiClient.java 75.15% <0.00%> (+0.31%) ⬆️
...in/java/com/iterable/iterableapi/IterableUtil.java 70.53% <0.00%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bdd227...0fe54c8. Read the comment docs.

@Ayyanchira Ayyanchira requested a review from vbabenkoru March 5, 2021 23:01
@Ayyanchira Ayyanchira merged commit 4308155 into master Mar 11, 2021
@Ayyanchira Ayyanchira deleted the MOB-2656-Handle-InAppDismiss-after-minimizing-the-app branch March 11, 2021 17:55
vbabenkoru pushed a commit that referenced this pull request Mar 16, 2021
…ter-minimizing-the-app

[MOB - 2656] - InApp Dismiss to allow stateloss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal Exception: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState

3 participants