Skip to content

Conversation

@roninopf
Copy link
Contributor

@roninopf roninopf commented Apr 6, 2020

No description provided.

@roninopf roninopf requested a review from tapashmajumder April 6, 2020 21:48
@tapashmajumder
Copy link
Contributor

Sorry that the description of this jira issue needs to be changed.

Since, unlike Obj C and Swift, Javascript goes only by the method name and not the param names, we should name the methods as trackEvent and not track.

I think in the future we should also look at renaming and deprecating our SDK. But that is for later.

Copy link
Contributor

@tapashmajumder tapashmajumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@roninopf roninopf merged commit 9a3f3ed into master Apr 7, 2020
@roninopf roninopf deleted the MOB-1326-track-event branch April 7, 2020 19:01
lposen pushed a commit that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants