Skip to content

[MOB-3182] updatecart data fields #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2021
Merged

[MOB-3182] updatecart data fields #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8faaa5
add dataFields to CommerceItem serialization
roninopf Aug 4, 2021
83f4bf8
get rid of dataFields parameter in updateCart
roninopf Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,6 @@ public void trackEvent(String name, ReadableMap dataFields) {
public void updateCart(ReadableArray items) {
IterableLogger.v(TAG, "UpdateCart API");

JSONObject dataFieldsJson = null;

try {
if (dataFields != null) {
dataFieldsJson = Serialization.convertMapToJson(dataFields);
}
} catch (JSONException e) {
IterableLogger.e(TAG, "Failed converting JSON to object");
}

IterableApi.getInstance().updateCart(Serialization.commerceItemsFromReadableArray(items));
}

Expand Down
6 changes: 4 additions & 2 deletions android/src/main/java/com/iterable/reactnative/Serialization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ static List<CommerceItem> commerceItemsFromReadableArray(ReadableArray array) {
}

static CommerceItem commerceItemFromMap(JSONObject itemMap) throws JSONException {

String[] categories = null;
JSONArray categoriesArray = itemMap.optJSONArray("categories");

if (categoriesArray != null) {
for (int i = 0; i < categoriesArray.length(); i++) {
if (categories == null) {
Expand All @@ -92,6 +92,7 @@ static CommerceItem commerceItemFromMap(JSONObject itemMap) throws JSONException
categories[i] = categoriesArray.getString(i);
}
}

return new CommerceItem(itemMap.getString("id"),
itemMap.getString("name"),
itemMap.getDouble("price"),
Expand All @@ -100,7 +101,8 @@ static CommerceItem commerceItemFromMap(JSONObject itemMap) throws JSONException
itemMap.optString("description", null),
itemMap.optString("url", null),
itemMap.optString("imageUrl", null),
categories
categories,
itemMap.optJSONObject("dataFields")
);
}

Expand Down
4 changes: 3 additions & 1 deletion ios/RNIterableAPI/Serialization.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ extension CommerceItem {
let url = dict["url"] as? String
let imageUrl = dict["imageUrl"] as? String
let categories = dict["categories"] as? [String]
let dataFields = dict["dataFields"] as? [AnyHashable: Any]

return CommerceItem(id: id,
name: name,
Expand All @@ -99,7 +100,8 @@ extension CommerceItem {
description: description,
url: url,
imageUrl: imageUrl,
categories: categories)
categories: categories,
dataFields: dataFields)
}
}

Expand Down
4 changes: 3 additions & 1 deletion ts/Iterable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,9 @@ class IterableCommerceItem {
url?: string
imageUrl?: string
categories?: Array<string>
dataFields?: any

constructor(id: string, name: string, price: number, quantity: number, sku?: string, description?: string, url?: string, imageUrl?: string, categories?: Array<string>) {
constructor(id: string, name: string, price: number, quantity: number, sku?: string, description?: string, url?: string, imageUrl?: string, categories?: Array<string>, dataFields?: any | undefined) {
this.id = id
this.name = name
this.price = price
Expand All @@ -181,6 +182,7 @@ class IterableCommerceItem {
this.url = url
this.imageUrl = imageUrl
this.categories = categories
this.dataFields = dataFields
}
}

Expand Down