[MOB-12158] improve-iterable-ts-test-coverage #705

lposen · 2025-09-30T04:09:18Z

🔹 JIRA Ticket(s) if any

MOB-12158

✏️ Description

Improved test coverage of Iterable.ts

…ss from hanging

…for clarity

github-actions · 2025-09-30T04:10:26Z

Lines	Statements	Branches	Functions
	45.33% (214/472)	20.67% (37/179)	37.41% (58/155)

qltysh · 2025-09-30T04:10:38Z

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 6.76%.

File Coverage Changes

Path	File Coverage Δ	Indirect
src/core/classes/Iterable.ts	22.5
src/core/classes/IterableAuthResponse.ts	100.0	√
src/inApp/classes/IterableInAppMessage.ts	12.1	√

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

qltysh · 2025-09-30T04:11:30Z

All good ✅
_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

src/core/classes/Iterable.test.ts

…cture

…-coverage

Copilot

Pull Request Overview

This PR improves test coverage for the Iterable.ts file by relocating comprehensive test files and updating package dependencies. The changes aim to enhance code quality and maintainability of the Iterable React Native SDK.

Relocates test file from src/__tests__/Iterable.test.ts to src/core/classes/Iterable.test.ts with significant expansion of test cases
Updates package dependencies including React Navigation, Testing Library, and various React Native packages
Adds timeout handling improvements to prevent process hanging in production code

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/core/classes/Iterable.test.ts`	New comprehensive test file with 915 lines covering all major Iterable functionality
`src/__tests__/Iterable.test.ts`	Original test file removed (433 lines deleted)
`src/core/classes/Iterable.ts`	Added `unref()` calls to timeouts to prevent process hanging
`src/__mocks__/MockRNIterableAPI.ts`	Enhanced mock with additional methods and resolved promises
`package.json`	Updated dependencies and added test watch script
`tsdoc.json`	Simplified configuration by removing TypeDoc plugin extensions

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-06T21:17:20Z

src/core/classes/Iterable.ts

+          // Use unref() to prevent the timeout from keeping the process alive
+          timeoutId.unref();


The unref() method is a Node.js-specific API that doesn't exist in React Native environments. This will cause a runtime error when the code runs on mobile devices.

Suggested change

// Use unref() to prevent the timeout from keeping the process alive

timeoutId.unref();

// In Node.js, you might use timeoutId.unref() to prevent the timeout from keeping the process alive.

// In React Native, unref() is not available and not needed.

Copilot · 2025-10-06T21:17:20Z

src/core/classes/Iterable.ts

+              // Use unref() to prevent the timeout from keeping the process alive
+              timeoutId.unref();


The unref() method is a Node.js-specific API that doesn't exist in React Native environments. This will cause a runtime error when the code runs on mobile devices.

Suggested change

// Use unref() to prevent the timeout from keeping the process alive

timeoutId.unref();

// In React Native, unref() is not available and not needed

Is it good to ignore?

Ayyanchira

LGTM

Ayyanchira · 2025-10-08T18:42:48Z

yarn.lock

+"@react-navigation/native@npm:^6.0.8":
  version: 6.1.18
  resolution: "@react-navigation/native@npm:6.1.18"
  dependencies:
    "@react-navigation/core": ^6.4.17
    escape-string-regexp: ^4.0.0
    fast-deep-equal: ^3.1.3
    nanoid: ^3.1.23
  peerDependencies:
    react: "*"
    react-native: "*"
  checksum: 82aeea67723f5dc41403e1c260f04942696f6cde95e30629c383521c3837d18d2d5c21bd78f0ade50beb81ac5edca2d7d38980dcd3a79e3acc86f45d0c09a4b8
  languageName: node
  linkType: hard

+"@react-navigation/native@npm:^7.1.14":


Do both of them same name with different version stay?

Ayyanchira · 2025-10-08T18:47:35Z

src/core/classes/Iterable.ts

+              // Use unref() to prevent the timeout from keeping the process alive
+              timeoutId.unref();


Is it good to ignore?

Ayyanchira · 2025-10-08T18:54:08Z

src/core/classes/Iterable.test.ts

Impressive test suite with clear comments to follow along

lposen added 5 commits September 29, 2025 19:32

chore: update Jest configuration and dependencies

6f75a38

test: add test coverage to Iterable.tsx

33f1bf3

chore: update package dependencies and add watch mode for Jest tests

46d1949

refactor: improve timeout handling in Iterable class to prevent proce…

4aad4dd

…ss from hanging

test: enhance Iterable test suite with additional cases and refactor …

c2d7d57

…for clarity

qltysh bot reviewed Sep 30, 2025

View reviewed changes

src/core/classes/Iterable.test.ts Show resolved Hide resolved

lposen and others added 2 commits September 29, 2025 21:46

chore: update typedoc to version 0.28.13 and clean up tsdoc.json stru…

b3d02be

…cture

Merge branch 'master' into feature/MOB-12158-improve-iterable-ts-test…

8894434

…-coverage

lposen requested a review from Copilot October 6, 2025 21:16

Copilot AI reviewed Oct 6, 2025

View reviewed changes

refactor: remove timeout unref

5917c04

Ayyanchira approved these changes Oct 8, 2025

View reviewed changes

lposen merged commit 763709c into master Oct 8, 2025
13 checks passed

lposen deleted the feature/MOB-12158-improve-iterable-ts-test-coverage branch October 8, 2025 20:01

		// Use unref() to prevent the timeout from keeping the process alive
		timeoutId.unref();

	// Use unref() to prevent the timeout from keeping the process alive
	timeoutId.unref();
	// In React Native, unref() is not available and not needed

[MOB-12158] improve-iterable-ts-test-coverage #705

[MOB-12158] improve-iterable-ts-test-coverage #705

Uh oh!

Conversation

lposen commented Sep 30, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Uh oh!

github-actions bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira left a comment

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lposen commented Sep 30, 2025 •

edited by atlassian bot

Loading

github-actions bot commented Sep 30, 2025 •

edited

Loading

qltysh bot commented Sep 30, 2025 •

edited

Loading

qltysh bot commented Sep 30, 2025 •

edited

Loading