Skip to content

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Oct 7, 2025

🔹 JIRA Ticket(s) if any

✏️ Description

Updates the frontend code for authentication

Testing

The easiest way to test this would actually be to test another PR which pulls in this code -- EG: #727

@qltysh
Copy link

qltysh bot commented Oct 7, 2025

1 new issue

Tool Category Rule Count
qlty Structure Function with many returns (count = 8): IterableAppProvider 1

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@lposen lposen changed the base branch from master to jwt/all October 7, 2025 04:23
@lposen lposen changed the base branch from jwt/all to jwt/master October 9, 2025 10:51
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Lines Statements Branches Functions
Coverage: 47%
47.43% (222/468) 22.04% (41/186) 41.13% (65/158)

@qltysh
Copy link

qltysh bot commented Oct 10, 2025

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 0.45%.

File Coverage Changes
Path File Coverage Δ Indirect
src/core/classes/Iterable.ts 0.1
src/core/classes/IterableAuthManager.ts 100.0
src/core/enums/IterableAuthFailureReason.ts 100.0
src/core/enums/IterableRetryBackoff.ts 100.0
src/core/types/IterableAuthFailure.ts 100.0
src/core/types/IterableRetryPolicy.ts 100.0
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@lposen lposen changed the title [MOB-10946] task 2 authfailure and retrypolicy ts classes [MOB-10946] JWT ts classes Oct 14, 2025
@lposen lposen changed the title [MOB-10946] JWT ts classes [MOB-10946] Update JWT in ts Oct 14, 2025
@lposen lposen added the jwt label Oct 14, 2025
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some comments

export { type IterableEdgeInsetDetails } from './core/types';
export type {
IterableAuthFailure,
IterableEdgeInsetDetails,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if EdgeInsetDetails falls under JWT changes. But is it for the inapp display issue?

Comment on lines +39 to +43
passAlongAuthToken(
authToken: string | null | undefined
): Promise<IterableAuthResponse | string | undefined> {
return RNIterableAPI.passAlongAuthToken(authToken);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a complimentary method where TS layer can pass authToken as and when needed outside the regular loop of JWT mechanism?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, just looked above file changes and saw its used internally. Is this method public?

@Ayyanchira Ayyanchira self-requested a review October 14, 2025 20:35
@lposen lposen mentioned this pull request Oct 14, 2025
@lposen lposen merged commit 0eedca5 into jwt/master Oct 14, 2025
9 checks passed
@lposen lposen deleted the jwt/MOB-10946-task-2-authfailure-and-retrypolicy-ts-classes branch October 14, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants