-
Notifications
You must be signed in to change notification settings - Fork 39
[MOB-10946] Update JWT in ts #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOB-10946] Update JWT in ts #726
Conversation
1 new issue
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
Show resolved
Hide resolved
android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
Show resolved
Hide resolved
android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
Show resolved
Hide resolved
android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
Show resolved
Hide resolved
android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
Show resolved
Hide resolved
android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
Show resolved
Hide resolved
…in Iterable class
…reReason enum values
…line configuration
…etrypolicy-ts-classes
|
Diff Coverage: The code coverage on the diff in this pull request is 100.0%. Total Coverage: This PR will increase coverage by 0.45%. File Coverage Changes
🛟 Help
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments
| export { type IterableEdgeInsetDetails } from './core/types'; | ||
| export type { | ||
| IterableAuthFailure, | ||
| IterableEdgeInsetDetails, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if EdgeInsetDetails falls under JWT changes. But is it for the inapp display issue?
| passAlongAuthToken( | ||
| authToken: string | null | undefined | ||
| ): Promise<IterableAuthResponse | string | undefined> { | ||
| return RNIterableAPI.passAlongAuthToken(authToken); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a complimentary method where TS layer can pass authToken as and when needed outside the regular loop of JWT mechanism?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, just looked above file changes and saw its used internally. Is this method public?
🔹 JIRA Ticket(s) if any
✏️ Description
Updates the frontend code for authentication
Testing
The easiest way to test this would actually be to test another PR which pulls in this code -- EG: #727