[MOB-12298] Improve the logger #739

lposen · 2025-10-10T21:21:34Z

🔹 JIRA Ticket(s) if any

MOB-12298

✏️ Description

Changed the methods on the logger to be static, minimizing the need for circular dependencies.

Testing

Build the app with config.logReactNativeSdkCalls = true. Make sure the logs show.
Build the app with config.logReactNativeSdkCalls = false. Make sure the logs do not show.

…gger functionality

… test structure

…' into jwt/MOB-12298-new-improve-logger

github-actions · 2025-10-10T21:23:07Z

Lines	Statements	Branches	Functions
	56.8% (309/544)	29.04% (61/210)	55.72% (112/201)

qltysh · 2025-10-10T21:23:10Z

Diff Coverage: The code coverage on the diff in this pull request is 93.9%.

Total Coverage: This PR will increase coverage by 4.67%.

File Coverage Changes

Path	File Coverage Δ	Indirect
src/core/classes/Iterable.ts	0.1
src/core/classes/IterableLogger.ts	25.0

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

…-out IterableLogger calls

…' into jwt/MOB-12298-new-improve-logger

github-actions · 2025-10-10T21:42:49Z

🚀 Deployed on https://jwt-mob-12298-new-improve-logger--iterable-react-native-sdk.netlify.app

…' into jwt/MOB-12298-new-improve-logger

…ples

…e/react-native-sdk into jwt/MOB-12298-new-improve-logger

Ayyanchira

Made two comments.

The two config values for log
Default state of logging

Ayyanchira · 2025-10-17T18:10:57Z

src/core/classes/IterableLogger.test.ts

+    test('should have default logging enabled', () => {
+      expect(IterableLogger.loggingEnabled).toBe(true);
+    });
+
+    test('should have default log level as info', () => {
+      expect(IterableLogger.logLevel).toBe(IterableLogLevel.info);
+    });


Default should be debug. Info would add lot many logs and can be noisy

Yeah that's totally fair. Changed it.

Ayyanchira · 2025-10-17T18:12:56Z

src/core/classes/Iterable.ts

+    if (config) {
+      Iterable.savedConfig = config;
+
+      IterableLogger.setLoggingEnabled(config.logReactNativeSdkCalls ?? true);


So whats the two log config?

The two config values that are set are:

Whether anything is going to be logged at all (config.logReactNativeSdkCalls --> IterableLogger.loggingEnabled)

If things are being logged, how granular those logs are going to be (config.logLevel --> IterableLogger.logLevel)

I think that's what you were asking. Let me know if I misinterpreted the question.

Ayyanchira · 2025-10-17T18:13:45Z

src/__tests__/IterableInApp.test.ts

-    return await Iterable.inAppManager?.getMessages().then((messagesObtained) => {
-      expect(messagesObtained).toEqual(messages);
-    });
+    return await Iterable.inAppManager
+      ?.getMessages()
+      .then((messagesObtained) => {
+        expect(messagesObtained).toEqual(messages);
+      });
  });

  test('showMessage_messageAndConsume_returnsClickedUrl', async () => {
    // GIVEN an in-app message and a clicked url
    const messageDict = {
      messageId: 'message1',
      campaignId: 1234,
      trigger: { type: IterableInAppTriggerType.immediate },
    };
    const message: IterableInAppMessage =
      IterableInAppMessage.fromDict(messageDict);
    const consume: boolean = true;
    const clickedUrl: string = 'testUrl';

    // WHEN the simulated clicked url is set to the clicked url
    MockRNIterableAPI.setClickedUrl(clickedUrl);
    // THEN Iterable,inAppManager.showMessage returns the simulated clicked url
-    return await Iterable.inAppManager?.showMessage(message, consume).then((url) => {
-      expect(url).toEqual(clickedUrl);
-    });
+    return await Iterable.inAppManager
+      ?.showMessage(message, consume)
+      .then((url) => {
+        expect(url).toEqual(clickedUrl);
+      });
  });


Not logging related as such.

This was automatically done by my automatic formatter :/

…ated tests

lposen · 2025-10-17T19:08:07Z

Made two comments.

The two config values for log

Default state of logging

@Ayyanchira Responded to these!

Ayyanchira

Looks good :)

lposen added 3 commits October 10, 2025 14:08

refactor: streamline logging in Iterable class and enhance IterableLo…

9be2327

…gger functionality

refactor: remove IterableLogger instantiation from tests and clean up…

de4db13

… test structure

Merge branch 'jwt/MOB-12231-create-an-iterableapi-class-for-api-calls…

3990876

…' into jwt/MOB-12298-new-improve-logger

lposen added 2 commits October 10, 2025 14:24

refactor: enable logging in IterableApi methods by removing commented…

cbd2799

…-out IterableLogger calls

test: add comprehensive unit tests for IterableLogger functionality

2025291

lposen added the documentation Improvements or additions to documentation label Oct 10, 2025

Merge branch 'jwt/MOB-12231-create-an-iterableapi-class-for-api-calls…

307326e

…' into jwt/MOB-12298-new-improve-logger

Merge branch 'jwt/MOB-12231-create-an-iterableapi-class-for-api-calls…

0af6532

…' into jwt/MOB-12298-new-improve-logger

lposen added the jwt label Oct 14, 2025

lposen changed the title ~~[MOB-12298] new-improve-logger~~ [MOB-12298] Improve the logger Oct 14, 2025

lposen mentioned this pull request Oct 14, 2025

[MOB-9064] JWT #740

Draft

Merge branch 'jwt/MOB-12231-create-an-iterableapi-class-for-api-calls…

2fa18f8

…' into jwt/MOB-12298-new-improve-logger

lposen marked this pull request as ready for review October 14, 2025 23:32

lposen and others added 3 commits October 14, 2025 16:46

Merge branch 'jwt/MOB-12231-create-an-iterableapi-class-for-api-calls…

644c510

…' into jwt/MOB-12298-new-improve-logger

docs: enhance IterableLogger documentation with descriptions and exam…

a693494

…ples

Merge branch 'jwt/MOB-12298-new-improve-logger' of github.com:Iterabl…

54f4626

…e/react-native-sdk into jwt/MOB-12298-new-improve-logger

Base automatically changed from jwt/MOB-12231-create-an-iterableapi-class-for-api-calls to jwt/master October 16, 2025 00:20

Ayyanchira self-requested a review October 17, 2025 16:04

Merge branch 'jwt/master' into jwt/MOB-12298-new-improve-logger

a4bd708

Ayyanchira reviewed Oct 17, 2025

View reviewed changes

lposen and others added 4 commits October 17, 2025 11:39

docs: removed a TODO and enhanced documentation for IterableLogger

c0a2c20

Merge branch 'jwt/master' into jwt/MOB-12298-new-improve-logger

e06edab

fix: change default log level from info to debug in IterableConfig

6828a7a

refactor: update default log level to debug in IterableLogger and rel…

e2c6148

…ated tests

Ayyanchira self-requested a review October 17, 2025 19:24

Ayyanchira approved these changes Oct 17, 2025

View reviewed changes

lposen merged commit d695a8b into jwt/master Oct 17, 2025
3 of 6 checks passed

lposen deleted the jwt/MOB-12298-new-improve-logger branch October 17, 2025 19:31

[MOB-12298] Improve the logger #739

[MOB-12298] Improve the logger #739

Uh oh!

Conversation

lposen commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Testing

Uh oh!

github-actions bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ayyanchira left a comment

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

lposen Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

lposen Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

lposen Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

lposen commented Oct 17, 2025

Uh oh!

Ayyanchira left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lposen commented Oct 10, 2025 •

edited

Loading

github-actions bot commented Oct 10, 2025 •

edited

Loading

qltysh bot commented Oct 10, 2025 •

edited

Loading

github-actions bot commented Oct 10, 2025 •

edited

Loading