-
Notifications
You must be signed in to change notification settings - Fork 39
[MOB-12360] release-2-0-4 #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Diff Coverage: The code coverage on the diff in this pull request is 100.0%. Total Coverage: This PR will not change total coverage. 🛟 Help
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with an optional suggestion
CHANGELOG.md
Outdated
| [#675](https://github.com/Iterable/react-native-sdk/issues/675) | ||
| ([6ece6e0](https://github.com/Iterable/react-native-sdk/commit/6ece6e0)) | ||
| - Updated dependencies | ||
| - Added unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem with Unit tests update in changelog. Just that we have never done before. Usually its more around what changed from's developer's perspective who use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point. I'll take it out.
🔹 JIRA Ticket(s) if any
✏️ Description
PR for new release