[SDK-136] Add Jwt Generator to Example app #767

lposen · 2025-10-21T03:20:58Z

🔹 JIRA Ticket(s) if any

SDK-136

✏️ Description

Adds JWT Generator to the example app

Testing

Create a new mobile api key with jwt enabled

In example/.env, add the following:

 ITBL_API_KEY=YOUR_NEW_API_KEY
 ITBL_JWT_SECRET=YOUR_JWT_SECRET
 ITBL_IS_JWT_ENABLED=true

Run yarn start
In a separate tab, run yarn ios
In a separate tab, run yarn android
Try login -- login should be successful in both android and iOS

…comments

… yarn.lock

…ation in React Native

…andling in IterableAppProvider

github-actions · 2025-10-21T03:22:40Z

Lines	Statements	Branches	Functions
	57.27% (315/550)	30.45% (67/220)	55.94% (113/202)

…o clean up the implementation

…in IterableAppProvider

…ider

lposen · 2025-10-21T03:33:24Z

example/src/hooks/useIterableApp.tsx

          setLoginInProgress(false);
          return Promise.reject(err);
-        })
-        .finally(() => {


Realized if you set the userid/email before calling initialize then you don't get this error.

This is super unintuitive. Do you know if it's documented anywhere?

I could also put this in a separate ticket if you'd like. It would probably be cleaner.

…ove old utility index

qltysh · 2025-10-21T03:38:59Z

4 new issues

Tool	Category	Rule	Count
qlty	Structure	Function with many parameters (count = 4): generateToken	2
qlty	Structure	Function with high complexity (count = 7): generateToken	1
qlty	Structure	Function with many returns (count = 10): IterableAppProvider	1

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

example/android/app/src/main/java/iterable/reactnativesdk/example/IterableJwtGenerator.java

example/android/app/src/main/java/iterable/reactnativesdk/example/JwtTokenModule.kt

example/ios/IterableJwtGenerator.swift

example/android/app/src/main/java/iterable/reactnativesdk/example/IterableJwtGenerator.java

example/android/app/src/main/java/iterable/reactnativesdk/example/JwtTokenModule.kt

example/ios/IterableJwtGenerator.swift

Copilot

Pull Request Overview

This PR adds JWT token generation capabilities to the example app, enabling authentication with JWT-enabled API keys. The implementation includes native modules for both iOS and Android platforms that generate JWT tokens client-side, along with configuration updates to support JWT-enabled workflows.

Key changes:

Native JWT token generation modules for iOS (Swift) and Android (Kotlin/Java)
Integration of JWT authentication handler in the example app's Iterable configuration
Documentation updates with setup instructions for JWT-enabled API keys

Reviewed Changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/core/classes/Iterable.ts	Removed unused timeout reference cleanup
ios/RNIterableAPI/ReactIterableAPI.swift	Code formatting improvements and explicit property access
example/src/hooks/useIterableApp.tsx	Added JWT token generation logic and auth handler configuration
example/src/NativeJwtTokenModule.ts	New module interface for JWT token generation with TurboModule support
example/ios/ReactNativeSdkExample.xcodeproj/project.pbxproj	Added Swift JWT generator files to Xcode project
example/ios/ReactNativeSdkExample-Bridging-Header.h	Added React Native bridge imports
example/ios/JwtTokenModule.swift	Swift implementation of JWT token generation module
example/ios/JwtTokenModule.mm	Objective-C++ bridge for JWT token module
example/ios/IterableJwtGenerator.swift	Core JWT generation logic for iOS
example/android/app/src/main/java/iterable/reactnativesdk/example/MainApplication.kt	Registered JWT token package
example/android/app/src/main/java/iterable/reactnativesdk/example/JwtTokenPackage.kt	Android package definition for JWT module
example/android/app/src/main/java/iterable/reactnativesdk/example/JwtTokenModule.kt	Kotlin bridge for JWT token generation
example/android/app/src/main/java/iterable/reactnativesdk/example/IterableJwtGenerator.java	Core JWT generation logic for Android
example/README.md	Updated setup instructions with JWT configuration
example/.env.example	Added JWT-related environment variables

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-21T03:42:15Z

example/ios/IterableJwtGenerator.swift

+      var iat = Int(Date().timeIntervalSince1970)
+      var exp = Int(Date().timeIntervalSince1970) + 60


The Payload struct defines hardcoded default values for iat and exp that are overridden by the initializer parameters. These default values should be removed since they are misleading and never used (the struct is always initialized with explicit values from the function parameters). The same issue exists in the generateJwtForUserId function.

Copilot · 2025-10-21T03:42:15Z

example/.env.example

+# Your JWT Secret, created when making your API key (see above)
+ITBL_JWT_SECRET=replace_this_with_your_jwt_secret
+# Is your api token JWT Enabled?
+# Defaults to true


The comment 'Defaults to true' is misleading. According to the code in useIterableApp.tsx, JWT is only enabled when explicitly set to the string 'true', not by default. This comment should be removed or clarified to state that this value must be explicitly set.

Suggested change

# Defaults to true

# Must be set to 'true' to enable JWT authentication

Copilot · 2025-10-21T03:42:16Z

example/src/hooks/useIterableApp.tsx

        });
    },
-    [apiKey, getUserId, login]
+    [getUserId, apiKey, login, getJwtToken]


The dependency array is missing userId which is used inside getJwtToken. While getJwtToken is in the array, its own dependency on userId means that userId should also be included to ensure proper memoization.

Suggested change

[getUserId, apiKey, login, getJwtToken]

[getUserId, apiKey, login, getJwtToken, userId]

example/android/app/src/main/java/iterable/reactnativesdk/example/IterableJwtGenerator.java

example/android/app/src/main/java/iterable/reactnativesdk/example/JwtTokenModule.kt

example/ios/IterableJwtGenerator.swift

example/android/app/src/main/java/iterable/reactnativesdk/example/IterableJwtGenerator.java

example/android/app/src/main/java/iterable/reactnativesdk/example/JwtTokenModule.kt

example/ios/IterableJwtGenerator.swift

…ents for clarity

qltysh · 2025-10-21T16:04:21Z

example/android/app/src/main/java/iterable/reactnativesdk/example/IterableJwtGenerator.java

+   public static String generateToken(
+       String secret, Duration duration, String email, String userId) {
+
+       if (duration.compareTo(maxTokenLifetime) > 0)
+           throw new IllegalArgumentException(
+               "Duration must be one year or less."
+           );
+
+       if ((userId != null && email != null) || (userId == null && email == null))
+           throw new IllegalArgumentException(
+               "The token must include a userId or email, but not both."
+           );
+
+       long now = millisToSeconds(System.currentTimeMillis());
+
+       String payload;
+       if (userId != null)
+           payload = String.format(
+               "{ \"userId\": \"%s\", \"iat\": %d, \"exp\": %d }",
+               userId, now, now + millisToSeconds(duration.toMillis())
+           );
+       else
+           payload = String.format(
+               "{ \"email\": \"%s\", \"iat\": %d, \"exp\": %d }",
+               email, now, now + millisToSeconds(duration.toMillis())
+           );
+
+       return generateToken(secret, payload);


Found 2 issues:

1. Function with high complexity (count = 7): generateToken [qlty:function-complexity]

2. Function with many parameters (count = 4): generateToken [qlty:function-parameters]

qltysh · 2025-10-21T16:04:21Z

example/android/app/src/main/java/iterable/reactnativesdk/example/JwtTokenModule.kt

+    fun generateJwtToken(
+        secret: String,
+        durationMs: Double,
+        email: String?,
+        userId: String?,
+        promise: Promise


Function with many parameters (count = 5): generateJwtToken [qlty:function-parameters]

Ayyanchira

Omg! This is one of RN's greated PR. Should bookmark this to show how a new module is created, implemented on both native layer, bridged and also used in the TS layer!
Wow fantastic!

Ayyanchira · 2025-10-21T16:12:00Z

example/src/NativeJwtTokenModule.ts

+try {
+  JwtTokenModule = isTurboModuleEnabled
+    ? TurboModuleRegistry.getEnforcing<Spec>('JwtTokenModule')
+    : NativeModules.JwtTokenModule;
+} catch {
+  // Module not available - will throw error when used


Seems interesting. Will look up during testing how turbo module works!

Yeah.. this is for backwards compatibility. If they have new architecture enabled, they'd use TurboModuleRegistry.getEnforcing<Spec>('JwtTokenModule'). Otherwise they'd fall back to NativeModules.JwtTokenModule

Ayyanchira · 2025-10-21T16:22:38Z

example/src/hooks/useIterableApp.tsx

+  const getJwtToken = useCallback(async () => {
+    const id = userId ?? process.env.ITBL_ID;
+    const idType = getIsEmail(id as string) ? 'email' : 'userId';
+    const secret = process.env.ITBL_JWT_SECRET ?? '';
+    const duration = 1000 * 60 * 60 * 24; // 1 day in milliseconds
+    const jwtToken = await NativeJwtTokenModule.generateJwtToken(
+      secret,
+      duration,
+      idType === 'email' ? (id as string) : null, // Email (can be null if userId is provided)
+      idType === 'userId' ? (id as string) : null // UserId (can be null if email is provided)
+    );
+
+    return jwtToken;
+  }, [userId]);


This is the main code! nice!

Ayyanchira · 2025-10-21T16:23:27Z

example/ios/ReactNativeSdkExample-Bridging-Header.h

 //  expose to Swift.
 //
+
+#import <React/RCTBridgeModule.h>


Great to know its going to be using native layer components.

Ayyanchira · 2025-10-21T16:25:23Z

example/ios/IterableJwtGenerator.swift

+import CryptoKit
+import Foundation
+
+@objcMembers public final class IterableJwtGenerator: NSObject {


Until I saw this, I was under the impression it will be using native layer's sample app code. Then I realized how! This makes sense. So now sample app in RN has its own native layer implementation! End to end native to TS layer work is implemented here! Great one Loren!

YAY! So glad you approve 😁

Ayyanchira · 2025-10-21T16:26:09Z

example/android/app/src/main/java/iterable/reactnativesdk/example/MainApplication.kt

            PackageList(this).packages.apply {
              // Packages that cannot be autolinked yet can be added manually here, for example:
              // add(MyReactNativePackage())
+              add(JwtTokenPackage())


Good to know this is how packages are added

Ayyanchira · 2025-10-21T16:26:38Z

example/android/app/src/main/java/iterable/reactnativesdk/example/JwtTokenPackage.kt

+import com.facebook.react.module.model.ReactModuleInfo
+import com.facebook.react.module.model.ReactModuleInfoProvider
+
+class JwtTokenPackage : BaseReactPackage() {


Package creation example! Great for team to understand how its done!

lposen added 7 commits October 20, 2025 17:01

chore: update yarn.lock and enhance example configuration documentation

2dcb969

chore: add .env.local to .gitignore and update example configuration …

1bfa9d5

…comments

refactor: small updates to ReactIterable.swift

d471800

feat: implement JWT generation module for React Native in example

6a9972a

chore: remove unused crypto-js and @types/crypto-js dependencies from…

ad48782

… yarn.lock

feat: add IterableJwtGenerator and JwtTokenModule for JWT token gener…

5df923f

…ation in React Native

fix: ensure login is called during initialization and improve error h…

40c4bad

…andling in IterableAppProvider

lposen added 3 commits October 20, 2025 20:23

refactor: remove commented-out code from IterableJwtGenerator.swift t…

fea6232

…o clean up the implementation

refactor: remove unnecessary login calls and clean up error handling …

fd76f08

…in IterableAppProvider

refactor: remove console log statements to streamline IterableAppProv…

b663dce

…ider

lposen commented Oct 21, 2025

View reviewed changes

feat: introduce NativeJwtTokenModule for JWT token generation and rem…

a58be2a

…ove old utility index

lposen changed the title ~~Jwt/SDK-136-new-jwt-token-generator~~ [SDK-136] Add Jwt Generator to Example app Oct 21, 2025

qltysh bot reviewed Oct 21, 2025

View reviewed changes

lposen added the jwt label Oct 21, 2025

lposen requested a review from Copilot October 21, 2025 03:41

qltysh bot reviewed Oct 21, 2025

View reviewed changes

lposen marked this pull request as ready for review October 21, 2025 03:41

Copilot AI reviewed Oct 21, 2025

View reviewed changes

qltysh bot reviewed Oct 21, 2025

View reviewed changes

refactor: enhance JWT generation methods and update .env.example comm…

13012d9

…ents for clarity

qltysh bot reviewed Oct 21, 2025

View reviewed changes

Ayyanchira approved these changes Oct 21, 2025

View reviewed changes

lposen merged commit 9038579 into jwt/master Oct 21, 2025
8 checks passed

lposen deleted the jwt/SDK-136-new-jwt-token-generator branch October 21, 2025 16:33

		var iat = Int(Date().timeIntervalSince1970)
		var exp = Int(Date().timeIntervalSince1970) + 60

	# Defaults to true
	# Must be set to 'true' to enable JWT authentication

	[getUserId, apiKey, login, getJwtToken]
	[getUserId, apiKey, login, getJwtToken, userId]

[SDK-136] Add Jwt Generator to Example app #767

[SDK-136] Add Jwt Generator to Example app #767

Uh oh!

Conversation

lposen commented Oct 21, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Testing

Uh oh!

github-actions bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qltysh bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh bot Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

qltysh bot Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Ayyanchira left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

lposen commented Oct 21, 2025 •

edited by atlassian bot

Loading

github-actions bot commented Oct 21, 2025 •

edited

Loading

qltysh bot commented Oct 21, 2025 •

edited

Loading