Skip to content

[MOB-2028] JWT bindings #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 14, 2020
Merged

[MOB-2028] JWT bindings #83

merged 13 commits into from
Oct 14, 2020

Conversation

@davidtruong
Copy link

@davidtruong davidtruong commented Oct 13, 2020 •
edited by vbabenkoru
Loading

JWT auth support for React Native.

tapashmajumder
tapashmajumder approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@tapashmajumder tapashmajumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

This is a provisional +1. And only for iOS and React Native. I have not reviewed Android.

Jay please do not merge until you have tested JWT end to end.

Ayyanchira
Ayyanchira reviewed Oct 13, 2020
View reviewed changes
Ayyanchira
Ayyanchira approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.. 🤞
Lets merge and test it out!!!

vbabenkoru
vbabenkoru reviewed Oct 13, 2020
View reviewed changes
@vbabenkoru vbabenkoru self-requested a review October 13, 2020 23:21
vbabenkoru
vbabenkoru approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@vbabenkoru vbabenkoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Haven't tested this since the dev app crashes on my emulator for some reason.

vbabenkoru
vbabenkoru reviewed Oct 14, 2020
View reviewed changes
vbabenkoru
vbabenkoru approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@vbabenkoru vbabenkoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vbabenkoru vbabenkoru changed the title Mob 2028 jwt bindings [MOB-2028] JWT bindings Oct 14, 2020
@roninopf roninopf merged commit 0826725 into master Oct 14, 2020
@roninopf roninopf deleted the MOB-2028-jwt-bindings branch October 14, 2020 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ayyanchira Ayyanchira Ayyanchira approved these changes

@vbabenkoru vbabenkoru vbabenkoru approved these changes

@roninopf roninopf Awaiting requested review from roninopf

+1 more reviewer

@tapashmajumder tapashmajumder tapashmajumder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@davidtruong @Ayyanchira @vbabenkoru @tapashmajumder @roninopf