Skip to content

[MOB-2281] remove backgroundAlpha #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2020
Merged

[MOB-2281] remove backgroundAlpha #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion android/src/main/java/com/iterable/reactnative/Serialization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ static JSONObject messageContentToJsonObject(IterableInAppMessage.Content conten

JSONObject messageContent = new JSONObject();
try {
messageContent.put("backgroundAlpha", content.backgroundAlpha);
messageContent.put("edgeInsets", content.padding);
messageContent.put("html", content.html);
if (messageContent.length() == 0) {
Expand Down
1 change: 0 additions & 1 deletion ios/RNIterableAPI/Serialization.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ extension IterableHtmlInAppContent {
var dict = [AnyHashable: Any]()
dict["type"] = type.rawValue
dict["edgeInsets"] = edgeInsets.toDict()
dict["backgroundAlpha"] = backgroundAlpha
dict["html"] = html
return dict
}
Expand Down
5 changes: 1 addition & 4 deletions ts/IterableInAppClasses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,19 +85,16 @@ export interface IterableInAppContent {
class IterableHtmlInAppContent implements IterableInAppContent {
type: IterableInAppContentType = IterableInAppContentType.html
edgeInsets: IterableEdgeInsets
backgroundAlpha: number
html: string

constructor(edgeInsets: IterableEdgeInsets, backgroundAlpha: number, html: string) {
constructor(edgeInsets: IterableEdgeInsets, html: string) {
this.edgeInsets = edgeInsets
this.backgroundAlpha = backgroundAlpha
this.html = html
}

static fromDict(dict: any): IterableHtmlInAppContent {
return new IterableHtmlInAppContent(
IterableEdgeInsets.fromDict(dict["edgeInsets"]),
dict["backgroundAlpha"] as number,
dict["html"] as string)
}
}
Expand Down