Crash on `exists` check

[ItzNotABug]

Hello @ItzNotABug,
Thanks for this optimization, which makes my life so much easier!
However I reproduce the problem when the file associated with the uri has been deleted. The original lib returns a DocumentFile on which I can perform an exists() which returns false, the DocumentFileCompat crashes with the error message java.lang.IllegalArgumentException: Failed to determine if primary:Pictures/xxxxxxxxxxxx is child of primary:Pictures/xxxxxxxxx java.io.FileNotFoundException: Missing file for primary:Pictures/xxxxxxxxxx

Do you have an idea for fixing the lib aside catch the exception in my app? Thanks a lot!

Originally posted by @provalinf in #6 (comment)

[ItzNotABug]

@provalinf I've created a separate issue for better tracking.

[ItzNotABug]

@provalinf This fix is now available on maven central. Update to 1.0.9.

[provalinf]

@ItzNotABug Thx but same problem, crash is (also?) before exist() on fromSingleUri() call

Of course, I'll return null, but the best practice would be to have the object to call exist() on.

[ItzNotABug]

@ItzNotABug Thx but same problem, crash is (also?) before exist() on fromSingleUri() call

I'll take a look at it again! Can you share a full stacktrace though?

[provalinf]

FATAL EXCEPTION: main
                 Process: com.yyyy.xxxx.android.debug, PID: 8424
                 java.lang.IllegalArgumentException: Failed to determine if primary:Pictures/xxxx/24-11-14_10-47-40-741_13241_3981_resi_20241114104744.jpg is child of primary:Pictures/xxxx: java.io.FileNotFoundException: Missing file for primary:Pictures/xxxx/24-11-14_10-47-40-741_13241_3981_resi_20241114104744.jpg at /storage/emulated/0/Pictures/xxxx/24-11-14_10-47-40-741_13241_3981_resi_20241114104744.jpg
                 	at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:172)
                 	at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:142)
                 	at android.content.ContentProviderProxy.query(ContentProviderNative.java:495)
                 	at android.content.ContentResolver.query(ContentResolver.java:1229)
                 	at android.content.ContentResolver.query(ContentResolver.java:1161)
                 	at android.content.ContentResolver.query(ContentResolver.java:1117)
                 	at com.lazygeniouz.dfc.resolver.ResolverCompat.getCursor(ResolverCompat.kt:139)
                 	at com.lazygeniouz.dfc.file.internals.SingleDocumentFileCompat$Companion.make$dfc_release(SingleDocumentFileCompat.kt:99)
                 	at com.lazygeniouz.dfc.file.DocumentFileCompat$Companion.fromSingleUri(DocumentFileCompat.kt:222)
                 	at com.lazygeniouz.dfc.file.DocumentFileCompat.fromSingleUri(Unknown Source:2)
                 	at com.yyyy.xxxx.android.utils.FileCompatUtil.fromSingleUri(FileCompatUtil.java:25)
                 	at com.yyyy.xxxx.android.data.modelDTO.questionnaire.response.GalleryAnswerDTO.localFileExists(GalleryAnswerDTO.java:244)
                 	at com.yyyy.xxxx.android.view.fragment.GalleryActivityFragment.showImage(GalleryActivityFragment.java:170)
                 	at com.yyyy.xxxx.android.view.fragment.GalleryActivityFragment.lambda$onCreateView$2$com-yyyy-xxxx-android-view-fragment-GalleryActivityFragment(GalleryActivityFragment.java:87)
                 	at com.yyyy.xxxx.android.view.fragment.GalleryActivityFragment$$ExternalSyntheticLambda3.onItemClick(D8$$SyntheticClass:0)
                 	at com.yyyy.xxxx.android.view.adapter.GalleryAdapter.lambda$getView$0$com-yyyy-xxxx-android-view-adapter-GalleryAdapter(GalleryAdapter.java:151)
                 	at com.yyyy.xxxx.android.view.adapter.GalleryAdapter$$ExternalSyntheticLambda0.onClick(D8$$SyntheticClass:0)
                 	at android.view.View.performClick(View.java:7659)
                 	at android.view.View.performClickInternal(View.java:7636)
                 	at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
                 	at android.view.View$PerformClick.run(View.java:30156)
                 	at android.os.Handler.handleCallback(Handler.java:958)
                 	at android.os.Handler.dispatchMessage(Handler.java:99)
                 	at android.os.Looper.loopOnce(Looper.java:205)
                 	at android.os.Looper.loop(Looper.java:294)
                 	at android.app.ActivityThread.main(ActivityThread.java:8177)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)

[ItzNotABug]

@provalinf Thanks for the stacktrace.
What I see here is that the error could be mitigated here, I'll try to reproduce this issue locally and see what can we do.

[provalinf]

Ok, normally just like this you should be able to reproduce it :

DocumentFileCompat folderDir = getFileImageFolder();
DocumentFileCompat destinationFile = folderDir.findFile("image.jpg");
Uri fileUri = destinationFile.getUri();
// Wait delete image
DocumentFileCompat.fromSingleUri(context, fileUri);
// Crash

[ItzNotABug]

I see the issue now -

1. DocumentFile just stores the Context and the Uri on init.
2. Meanwhile DocumentFileCompat reaches to the ContentResolver on init and crashes when the file doesn't exist.

I'll shoot a PR for this. Thanks for all the details 🙌

[ItzNotABug]

I've merged the fix and released a new version to Maven Central (1.1).
Please note that availability on Maven Central can sometimes be delayed.