Mac build requires 10.12 (Sierra)

[unknown--]

Reporting a bug? Please make sure you've given the following information - thanks!

Operating system and version:

OS X - 10.11.4

Is this for single player or multiplayer?

Both

Description of the bug (and if possible, steps to reproduce the bug):

Mac builds since January are 10.12 only. Can you please explain why and if it's possible for the user to manually change the version requirement.

[ensiform]

@MazterQyou are you still hosting the builder? Wonder what would have changed here

@redsaurus @xycaleth

[MazterQyou]

I'm still hosting the builder, but I'm not configuring how it builds. Cat is in charge of that

[ensiform]

@deepy do you recall any configuration changes for mac builds recently?

[MazterQyou]

@unknown-- how did you figure that Sierra is required? Can you provide crashlog or something?

[deepy]

As far as I know there's been no configuration changes in the Mac builds for a long time

[unknown--]

@MazterQyou I get this message:

[deepy]

Maybe we should set https://cmake.org/cmake/help/v3.0/variable/CMAKE_OSX_DEPLOYMENT_TARGET.html

[deepy]

@unknown-- could you please try https://builds.openjk.org/openjk-2017-08-11-a0828f06-osx.dmg and see if that works?

[unknown--]

@deepy

I'm afraid it still gives the error.

[ensiform]

@deepy did you force a fresh build with rerun cmake without cache?

[Klezstyle]

The problem with that 2017-08-11 build is the path of the LibSDL2 library:

This is the straightforward error:
_

Termination Reason:    DYLD, [0x1] Library missing

Application Specific Information:
dyld: launch, loading dependent libraries

Dyld Error Message:
  Library not loaded: /usr/local/opt/sdl2/lib/libSDL2-2.0.0.dylib
  Referenced from: /Volumes/VOLUME/*/openjk_sp.x86_64.app/Contents/MacOS/openjk_sp.x86_64
  Reason: image not found

_

In macOS the SDL Library is:
"/Library/Frameworks/SDL2.framework"

[MazterQyou]

Looks like CMake is building against Homebrew SDL2. I guess cmake args have to be changed to force build against system SDL2.framework.
Although afaik macOS doesn’t cone with SDL2 at all. So it should actually be bundled inside app and rpaths have to be set correctly upon packaging a .dmg.

[ensiform]

Mind trying to rearrange that ? So it doesn't require homebrew? The current wiki and instructions seem to discuss requiring it.

[kencu]

I just built it on 10.6.8 without any trouble using MacPorts sudo port -v install openjk (also builds and runs on every system up to 10.13).