Fix opengl context leak on vid_restart #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her resource leaks) SDL opengl context must be destroyed before destroying its window and also before SDL_QuitSubSystem(SDL_INIT_VIDEO) to prevent leaks
Razish
approved these changes
May 1, 2024
Daggolin
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effect of opengl context leak varies depending on video driver. On my linux intel driver it was adding 4 new threads per vid_restart (+ heap space)
On windows + nvidia driver it didn't add new threads but each vid_restart added considerable amount of heap space to the process.
It's possible that the leak did not happen with some older SDL version, I tested with SDL2 2.28.5