Fix some compiler warnings #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like an extra NORETURN defined specifically for func ptrs to avoid the attribute in regular code. NORETURN_PTR maybe? |
Sure, I'll add NORETURN_PTR. |
|
Branch rebased and updated. |
|
I've done as requested in @ensiform's review. Please could someone take another look at this? |
|
This looks good to me. Next reviewer can go ahead and merge. |
xycaleth
requested changes
Jul 6, 2017
It issues compiler warnings (or did until recently), and git grep says nothing actually calls or mentions this function. Signed-off-by: Simon McVittie <smcv@debian.org>
clang can see that BufferRead() does not always assign to length, issuing this warning: IcarusImplementation.cpp|601 col 13| warning: ‘length’ may be used uninitialized in this function [-Wmaybe-uninitialized] (This only happens if the buffer is null, in which case we have bigger problems.) Signed-off-by: Simon McVittie <smcv@debian.org>
According to comments in code/game/g_public.h (whose version was already tagged noreturn), for function pointers this only works with the gcc/clang-specific spelling __attribute__((noreturn)), and not with the gcc/clang/MSVC abstraction NORETURN. For function implementations, we can use NORETURN to get MSVC support too. This lets the compiler reason about what returns and what doesn't, and in particular silences gcc warnings about functions that are declared NORETURN but that did appear to return. They didn't, because they ended with a call to (a function pointer that eventually calls) Com_Error, but without these annotations the compiler couldn't know that. Signed-off-by: Simon McVittie <smcv@debian.org>
Signed-off-by: Simon McVittie <smcv@debian.org>
This expands to the same thing as NORETURN on gcc (and clang), but expands to nothing on MSVC. Signed-off-by: Simon McVittie <smcv@debian.org>
Signed-off-by: Simon McVittie <smcv@debian.org>
|
@xycaleth: better now? I initially put For a lot of |
|
Much better :) |
Blackwolf1337
pushed a commit
to Blackwolf1337/JaVisionPlus
that referenced
this pull request
Jul 15, 2017
Fix some compiler warnings (JACoders#917)
deathsythe47
pushed a commit
to jkanewmod/NewJK
that referenced
this pull request
Aug 18, 2018
* Consistently declare Com_Error implementations as noreturn According to comments in code/game/g_public.h (whose version was already tagged noreturn), for function pointers this only works with the gcc/clang-specific spelling __attribute__((noreturn)), and not with the gcc/clang/MSVC abstraction NORETURN. For function implementations, we can use NORETURN to get MSVC support too. This lets the compiler reason about what returns and what doesn't, and in particular silences gcc warnings about functions that are declared NORETURN but that did appear to return. They didn't, because they ended with a call to (a function pointer that eventually calls) Com_Error, but without these annotations the compiler couldn't know that. Signed-off-by: Simon McVittie <smcv@debian.org> * AI_ClosestGroupEntityNumToPoint: Remove, unused It issues compiler warnings (or did until recently), and git grep says nothing actually calls or mentions this function. Signed-off-by: Simon McVittie <smcv@debian.org> * Icarus: Squash a compiler warning about possibly uninitialized length clang can see that BufferRead() does not always assign to length, issuing this warning: IcarusImplementation.cpp|601 col 13| warning: ‘length’ may be used uninitialized in this function [-Wmaybe-uninitialized] (This only happens if the buffer is null, in which case we have bigger problems.) Signed-off-by: Simon McVittie <smcv@debian.org> * Move definition of NORETURN to q_platform.h Signed-off-by: Simon McVittie <smcv@debian.org> * Introduce NORETURN_PTR, a version of NORETURN for function pointers This expands to the same thing as NORETURN on gcc (and clang), but expands to nothing on MSVC. Signed-off-by: Simon McVittie <smcv@debian.org> * Define NORETURN, NORETURN_PTR for non-gcc non-MSVC compilers Signed-off-by: Simon McVittie <smcv@debian.org>
deathsythe47
pushed a commit
to jkanewmod/NewJK
that referenced
this pull request
Aug 18, 2018
* Consistently declare Com_Error implementations as noreturn According to comments in code/game/g_public.h (whose version was already tagged noreturn), for function pointers this only works with the gcc/clang-specific spelling __attribute__((noreturn)), and not with the gcc/clang/MSVC abstraction NORETURN. For function implementations, we can use NORETURN to get MSVC support too. This lets the compiler reason about what returns and what doesn't, and in particular silences gcc warnings about functions that are declared NORETURN but that did appear to return. They didn't, because they ended with a call to (a function pointer that eventually calls) Com_Error, but without these annotations the compiler couldn't know that. Signed-off-by: Simon McVittie <smcv@debian.org> * AI_ClosestGroupEntityNumToPoint: Remove, unused It issues compiler warnings (or did until recently), and git grep says nothing actually calls or mentions this function. Signed-off-by: Simon McVittie <smcv@debian.org> * Icarus: Squash a compiler warning about possibly uninitialized length clang can see that BufferRead() does not always assign to length, issuing this warning: IcarusImplementation.cpp|601 col 13| warning: ‘length’ may be used uninitialized in this function [-Wmaybe-uninitialized] (This only happens if the buffer is null, in which case we have bigger problems.) Signed-off-by: Simon McVittie <smcv@debian.org> * Move definition of NORETURN to q_platform.h Signed-off-by: Simon McVittie <smcv@debian.org> * Introduce NORETURN_PTR, a version of NORETURN for function pointers This expands to the same thing as NORETURN on gcc (and clang), but expands to nothing on MSVC. Signed-off-by: Simon McVittie <smcv@debian.org> * Define NORETURN, NORETURN_PTR for non-gcc non-MSVC compilers Signed-off-by: Simon McVittie <smcv@debian.org>
eternalcodes
pushed a commit
to eternalcodes/EternalJK
that referenced
this pull request
Aug 21, 2018
* Consistently declare Com_Error implementations as noreturn According to comments in code/game/g_public.h (whose version was already tagged noreturn), for function pointers this only works with the gcc/clang-specific spelling __attribute__((noreturn)), and not with the gcc/clang/MSVC abstraction NORETURN. For function implementations, we can use NORETURN to get MSVC support too. This lets the compiler reason about what returns and what doesn't, and in particular silences gcc warnings about functions that are declared NORETURN but that did appear to return. They didn't, because they ended with a call to (a function pointer that eventually calls) Com_Error, but without these annotations the compiler couldn't know that. Signed-off-by: Simon McVittie <smcv@debian.org> * AI_ClosestGroupEntityNumToPoint: Remove, unused It issues compiler warnings (or did until recently), and git grep says nothing actually calls or mentions this function. Signed-off-by: Simon McVittie <smcv@debian.org> * Icarus: Squash a compiler warning about possibly uninitialized length clang can see that BufferRead() does not always assign to length, issuing this warning: IcarusImplementation.cpp|601 col 13| warning: ‘length’ may be used uninitialized in this function [-Wmaybe-uninitialized] (This only happens if the buffer is null, in which case we have bigger problems.) Signed-off-by: Simon McVittie <smcv@debian.org> * Move definition of NORETURN to q_platform.h Signed-off-by: Simon McVittie <smcv@debian.org> * Introduce NORETURN_PTR, a version of NORETURN for function pointers This expands to the same thing as NORETURN on gcc (and clang), but expands to nothing on MSVC. Signed-off-by: Simon McVittie <smcv@debian.org> * Define NORETURN, NORETURN_PTR for non-gcc non-MSVC compilers Signed-off-by: Simon McVittie <smcv@debian.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for details.
If any of the individual patches are not desired, the others can be cherry-picked.