-
Notifications
You must be signed in to change notification settings - Fork 49
Switched to travis-ci and test multiple django versions. #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| packages=find_packages(), | ||
| include_package_data=True, | ||
| install_requires=['Django>=1.8', 'dj-database-url==0.3.0'], | ||
| tests_require=['psycopg2==2.6.1', 'mysqlclient==1.3.7', 'mock==1.0.1', 'django_nose==1.4.2', 'coverage==4.0', 'coveralls==1.0', 'tox==2.1.1'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coverage and coveralls are needed only in the ci.
|
Nice work so far, I jus enabled travis for the repo so if it picks it up then on your next push it should be there alongside circle. |
|
Let me know if you'd like something from me. I can try to help, but you seem to be off in a good direction. |
|
How is this looking? I am all for moving over to travis, but watching travis fail in other pull requests because its not configured correctly in master yet sucks! |
|
sorry, travis-ci work after |
|
ummmm... I could not understand why failed this test. it's a normally django command call. https://travis-ci.org/JBKahn/django-sharding/jobs/128229439#L250 and that are not repeatability... |
|
Hmm I'll take a look tonight |
|
been super busy, I'll take a look right now. |
|
I think we'll have to change the test, it's a bug in Django with arg_parsing and depends on the return value of dict.items(). I'm going to open a PR to fix it in Django. For now, have it raise a skip test. |
|
Here's the bug report I filed: https://code.djangoproject.com/ticket/26597#ticket |
|
oh... thank you! skip that. |
Travis-CI results of my fork: See
TODO: