Skip to content

Conversation

@Surgo
Copy link
Contributor

@Surgo Surgo commented Apr 28, 2016

Travis-CI results of my fork: See

TODO:

  • Change badge in README.md

packages=find_packages(),
include_package_data=True,
install_requires=['Django>=1.8', 'dj-database-url==0.3.0'],
tests_require=['psycopg2==2.6.1', 'mysqlclient==1.3.7', 'mock==1.0.1', 'django_nose==1.4.2', 'coverage==4.0', 'coveralls==1.0', 'tox==2.1.1'],
Copy link
Contributor Author

@Surgo Surgo Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage and coveralls are needed only in the ci.

@JBKahn
Copy link
Owner

JBKahn commented Apr 28, 2016

Nice work so far, I jus enabled travis for the repo so if it picks it up then on your next push it should be there alongside circle.

@JBKahn
Copy link
Owner

JBKahn commented Apr 30, 2016

Let me know if you'd like something from me. I can try to help, but you seem to be off in a good direction.

@4word
Copy link
Contributor

4word commented May 3, 2016

How is this looking? I am all for moving over to travis, but watching travis fail in other pull requests because its not configured correctly in master yet sucks!

@coveralls
Copy link

coveralls commented May 6, 2016

Coverage Status

Coverage decreased (-0.2%) to 93.217% when pulling 61e85a4 on uncovertruth:master into 534d1fd on JBKahn:master.

@coveralls
Copy link

coveralls commented May 6, 2016

Coverage Status

Coverage decreased (-0.2%) to 93.217% when pulling 2c45d57 on uncovertruth:master into 534d1fd on JBKahn:master.

@Surgo
Copy link
Contributor Author

Surgo commented May 6, 2016

sorry, travis-ci work after push -f :(

@coveralls
Copy link

coveralls commented May 6, 2016

Coverage Status

Coverage decreased (-0.2%) to 93.217% when pulling 21cb183 on uncovertruth:master into 534d1fd on JBKahn:master.

@coveralls
Copy link

coveralls commented May 6, 2016

Coverage Status

Coverage decreased (-0.2%) to 93.217% when pulling 4bbca94 on uncovertruth:master into 534d1fd on JBKahn:master.

@coveralls
Copy link

coveralls commented May 6, 2016

Coverage Status

Coverage decreased (-0.2%) to 93.217% when pulling 9b3cc20 on uncovertruth:master into 534d1fd on JBKahn:master.

@Surgo
Copy link
Contributor Author

Surgo commented May 6, 2016

ummmm... I could not understand why failed this test. it's a normally django command call.

https://travis-ci.org/JBKahn/django-sharding/jobs/128229439#L250

# in tests/test_migration_command.py
        self.assertTrue(mock_migrate_command.call_args[1].get('fake'))  # passed
        self.assertTrue(mock_migrate_command.call_args[1].get('fake_initial'))  # passed
        self.assertFalse(mock_migrate_command.call_args[1].get('interactive'))  # failed

and that are not repeatability...

@JBKahn
Copy link
Owner

JBKahn commented May 6, 2016

Hmm I'll take a look tonight

@JBKahn
Copy link
Owner

JBKahn commented May 8, 2016

been super busy, I'll take a look right now.

@JBKahn
Copy link
Owner

JBKahn commented May 8, 2016

I think we'll have to change the test, it's a bug in Django with arg_parsing and depends on the return value of dict.items(). I'm going to open a PR to fix it in Django. For now, have it raise a skip test.

@JBKahn
Copy link
Owner

JBKahn commented May 8, 2016

Here's the bug report I filed: https://code.djangoproject.com/ticket/26597#ticket

@Surgo
Copy link
Contributor Author

Surgo commented May 9, 2016

oh... thank you! skip that.

@coveralls
Copy link

coveralls commented May 9, 2016

Coverage Status

Coverage decreased (-0.2%) to 93.217% when pulling 35fcdf8 on uncovertruth:master into 534d1fd on JBKahn:master.

@JBKahn JBKahn merged commit 44b4fdf into JBKahn:master May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants