Exclude tests from being packaged and installed. #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current use of find_packages, the "tests" package is discovered and installed alongside the django_sharding and django_sharding_packages. This appears to be unintentional, and we probably don't want users to accidentally get this test package. This change excludes it from being discovered during packaging.
|
This is true, please merge this pull request! |
Owner
|
Ok I'll get on it this week |
JBKahn
approved these changes
Jul 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current use of find_packages, the "tests" package is discovered and installed alongside the django_sharding and django_sharding_packages. This appears to be unintentional, and we probably don't want users to accidentally get this test package.
This change excludes it from being discovered during packaging.