Skip to content

Conversation

@lam2mo
Copy link
Member

@lam2mo lam2mo commented Feb 12, 2020

THIS IS NOT READY TO MERGE YET.

It is an initial attempt at streamlining/fixing the distribution files by copying over the lj script and making some modifications both to that script and to the Gradle configuration. The goal is to help close #23 by improving the end-user experience (e.g., they should be able to use Less-Java with just the compiled jarfile and the Bash script).

A remaining issue is that it still cannot find the LJ wrappers. I added a line to build.gradle that I thought would work but it doesn't seem to have fully integrated them into the jarfile. More debugging is needed before this can be merged, and perhaps someone with more Gradle experience (@Zamua ?) could move more quickly than I.

@lam2mo lam2mo requested a review from Zamua February 12, 2020 16:41
Copy link
Contributor

@Zamua Zamua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! We should consider adding some Travis testing for this script to prevent future regression #88

@lam2mo lam2mo merged commit 63f0124 into JMU-CS:master Feb 21, 2020
@lam2mo lam2mo deleted the streamline-distribution branch February 21, 2020 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streamline distribution/deployment

2 participants