Skip to content

Chore: update inquirer #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Docs: Fixed erroneous json comments
merged 1 commit into from
Dec 14, 2018
Merged

Chore: update inquirer #72

merged 1 commit into from
Dec 14, 2018

Conversation

@JPeer264
Copy link
Owner

Might fix #71 as of inquirer@3.2.0:

  • Bug: SIGINT was not properly exiting the process for some users

@JPeer264
Copy link
Owner Author

@anoblet unfortunately I can't test it on Windows, but I hope this will fix your issue.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 214153f on chore/update-inquirer into b30c854 on master.

@JPeer264 JPeer264 requested a review from aichbauer December 14, 2018 06:33
aichbauer
aichbauer approved these changes Dec 14, 2018
View reviewed changes
Copy link
Collaborator

@aichbauer aichbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JPeer264 JPeer264 merged commit 93ce722 into master Dec 14, 2018
@JPeer264 JPeer264 deleted the chore/update-inquirer branch June 12, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aichbauer aichbauer aichbauer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Non-responsive

3 participants

@JPeer264 @coveralls @aichbauer