Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributions document #27

Merged
merged 6 commits into from
May 20, 2016
Merged

Add contributions document #27

merged 6 commits into from
May 20, 2016

Conversation

leobalter
Copy link
Collaborator

Ref gh-24

Still need to collect and add more contributions.

Ref gh-24

Still need more contributions
@leobalter
Copy link
Collaborator Author

@scottgonzalez @rwaldron


| Proposal | Champion | Stage |
|----------|----------|-------|
| [String padding](https://github.com/tc39/proposal-string-pad-start-end) | Jordan Harband & Rick Waldron | 3 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more like I originally brought forward a proposal, but Jordan really gets the credit here. Would be nice if that was clearly stated

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objection to clarifying it, but imo no need either.

@scottgonzalez
Copy link
Collaborator

We should probably be consistent with how we list people. There's currently a mix of at-name, real name, real name with link to GitHub account. I think real name with link to GitHub account is the way to go.

@leobalter
Copy link
Collaborator Author

@scottgonzalez @rwaldron I believe fixed everything. On a follow up PR, I want to include a quick one-line introduction of the participants.

@scottgonzalez
Copy link
Collaborator

Looks good.

You might want to alphabetize the links at the bottom by name. This will make it easier to see if a name is already in the list when adding future contributions.

@leobalter
Copy link
Collaborator Author

Sure thing, I just did it.

| `Array.from` & `Array.of` | [ES2015][Array.from] | [Dave Herman] & [Rick Waldron] |
| `Array#find` & `Array#findIndex` | [ES2015][Array#find] | [Rick Waldron] |
| `Object.assign` | [ES2015][Object.assign] | [Rick Waldron] |
| Exponentiantion Operator (`**`) | [ES2016][Exp Operator] | [Rick Waldron] |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Exponentiantion/Exponentiation

@markelog
Copy link
Collaborator

markelog commented May 5, 2016

Can we mention @mikesherov and his involvement in estree (although, i'm not sure if that thing is still alive) and CSSWG? .

I also remembering @jaubourg was involved with xhr spec

@leobalter
Copy link
Collaborator Author

@markelog sure! You just pointed to information I didn't have before and this document can be improved anytime. Can we add them as a follow up PR so we land this as initial document?

@ljharb thanks! I just fixed the typo.

@mikesherov
Copy link

Thanks for the mention @markelog ;-)

@markelog
Copy link
Collaborator

markelog commented May 5, 2016

Can we add them as a follow up PR so we land this as initial document?

Totally. Estree is here - https://github.com/estree

@mikesherov, @jaubourg maybe you could provide other relevant links?

@mikesherov
Copy link

@ariya was involved heavily in ESTree as well.

Mike Sherov

On May 5, 2016, at 11:03 AM, Oleg Gaidarenko notifications@github.com wrote:

Can we add them as a follow up PR so we land this as initial document?

Totally. Estree is here - https://github.com/estree

@mikesherov, @jaubourg maybe you could provide other relevant links?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@leobalter leobalter merged commit d6c023c into master May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants