Skip to content

Conversation

@JSv4
Copy link
Collaborator

@JSv4 JSv4 commented Mar 8, 2025

Revamped permissioning logic to rely on Django Guardian more thoroughly and to pass corpus permissions through to child objects. Added test for queries and nested objects on corpuses.

@codecov
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 84.32000% with 98 lines in your changes missing coverage. Please review.

Project coverage is 89.17%. Comparing base (9a97509) to head (ea209e8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
opencontractserver/utils/permissioning.py 83.03% 48 Missing ⚠️
opencontractserver/shared/resolvers.py 18.51% 22 Missing ⚠️
opencontractserver/annotations/models.py 23.07% 10 Missing ⚠️
opencontractserver/shared/mixins.py 66.66% 6 Missing ⚠️
opencontractserver/shared/Models.py 73.33% 4 Missing ⚠️
opencontractserver/shared/QuerySets.py 71.42% 4 Missing ⚠️
...server/users/migrations/0015_auto_20250308_0649.py 92.00% 2 Missing ⚠️
opencontractserver/llms/vector_stores.py 90.90% 1 Missing ⚠️
opencontractserver/shared/Managers.py 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   89.63%   89.17%   -0.46%     
==========================================
  Files         261      264       +3     
  Lines       10515    10977     +462     
==========================================
+ Hits         9425     9789     +364     
- Misses       1090     1188      +98     
Files with missing lines Coverage Δ
opencontractserver/corpuses/models.py 92.38% <100.00%> (+0.14%) ⬆️
opencontractserver/documents/models.py 98.71% <100.00%> (+0.03%) ⬆️
...pencontractserver/tests/test_corpus_permissions.py 100.00% <100.00%> (ø)
...ractserver/tests/test_custom_permission_filters.py 100.00% <100.00%> (ø)
...contractserver/tests/test_document_analysis_row.py 100.00% <100.00%> (ø)
...ontractserver/tests/test_permissioned_querysets.py 100.00% <100.00%> (ø)
opencontractserver/tests/test_permissioning.py 100.00% <100.00%> (ø)
opencontractserver/llms/vector_stores.py 73.33% <90.90%> (+0.39%) ⬆️
opencontractserver/shared/Managers.py 61.29% <90.00%> (+2.03%) ⬆️
...server/users/migrations/0015_auto_20250308_0649.py 92.00% <92.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a97509...ea209e8. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSv4 JSv4 closed this Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants