Fixing potential issue where CreateCopy wasn't creating a copy.

Author: JaCraig

src/SQLHelper.DB/HelperClasses/BaseClasses/ParameterBase.cs

@@ -45,6 +45,15 @@ protected ParameterBase(string id, TDataType value, ParameterDirection direction
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="ParameterBase{TDataType}"/> class.
+        /// </summary>
+        /// <param name="parameter">The parameter.</param>
+        protected ParameterBase(ParameterBase<TDataType> parameter)
+            : this(parameter.ID, parameter.DatabaseType, parameter.Value, parameter.Direction, parameter.ParameterStarter)
+        {
+        }
+
         /// <summary>
         /// Constructor
         /// </summary>

src/SQLHelper.DB/HelperClasses/Parameter.cs

@@ -82,8 +82,7 @@ public override void AddParameter(DbCommand helper)
         /// <returns>A copy of the parameter</returns>
         public override IParameter CreateCopy(string suffix)
         {
-            ID += suffix;
-            return this;
+            return new Parameter<TDataType>(ID + suffix, DatabaseType, Value, Direction, ParameterStarter);
         }
     }
 }

src/SQLHelper.DB/HelperClasses/StringParameter.cs

@@ -35,7 +35,7 @@ public class StringParameter : ParameterBase<string>
         /// <param name="direction">Direction of the parameter</param>
         /// <param name="parameterStarter">Parameter starter</param>
         public StringParameter(string id, string value, ParameterDirection direction = ParameterDirection.Input, string parameterStarter = "@")
-            : base(id, value, direction, parameterStarter)
+            : base(id, DbType.String, value, direction, parameterStarter)
         {
         }
 
@@ -55,8 +55,7 @@ public override void AddParameter(DbCommand helper)
         /// <returns>A copy of the parameter</returns>
         public override IParameter CreateCopy(string suffix)
         {
-            ID += suffix;
-            return this;
+            return new StringParameter(ID + suffix, Value, Direction, ParameterStarter);
         }
     }
 }