-
Notifications
You must be signed in to change notification settings - Fork 10
initial version of JanusGraph-Python supporting JanusGraph 1.0 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
b050b5b to
3b4bfdc
Compare
FlorianHockmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this great contribution and sorry that you had to wait so long for a first review!
I just reviewed the PR and also tried out the library a bit. I basically only found some nits which I directly commented inline. Overall the PR already looks really good :)
Just 2 other general comments:
- It would be good to have GitHub Actions execute the tests automatically on every commit. So, some GH Actions config would be good to have. However, we can also do this in a follow-up contribution.
- Codacy reports some issues on this PR. This is our static code analysis tool. I think most of them are false positives, like it's complaining about the use of asserts in the tests. But maybe you can check them and see if Codacy reported any real issues which you could then fix. For the false positives, we can probably create exemptions in Codacy.
Signed-off-by: pm-osc <pm2.osc@gmail.com>
5337c45 to
ff2168d
Compare
FlorianHockmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. From my side, this is ready to be merged. I'd say we wait a few days in case someone else also wants to review this.
One thing to note for others: GH Actions doesn't run on this PR, although it contains config for GH Actions. However, it does work on the source branch of this PR in @pm-osc's fork: https://github.com/pm-osc/janusgraph-python/tree/jg1-initial-pr
I guess this is a security precaution from GitHub to not execute GH Actions in a PR which adds the action (?)
But the actions should work in our repo once this is merged. If not, then we should look into it.
JanusGraph-Python extends Apache TinkerPop™'s Gremlin-Python with support for JanusGraph-specific types. This version supports only GraphSON 3 serialization for RelationIdentifier and Text predicates. This version is compatible with JanusGraph 1.0.