fix message links and embeds in threads #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bot responds to message links with the content of the linked message.
However, this works only if the message link is sent in a text channel and not in threads.
This PR fixes the message link handler to also work in threads and forum posts.
Furthermore, it allows to use the
/embed createcommand to be used with threads/forum posts as well as this command would not find the channel in that case and display an error after sending the modal.Other
/embedcommands worked already.The checkstyle issues in
HugListeneraren't not caused by this PR and should be fixed in #429.(They were introduced by merging #428)