improve detection of codeblocks for autoformat #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bot attempts to automatically format messages containing code using codeblocks (#425).
This PR changes that behaviour so that messages are not formatted when the first
{and last}are on the same line and also not if a message contains even a single backtick (instead of three).The former is because things like
{something}probably don't need codeblocks and the latter is due to the assumption that messages containing backticks are probably formatted in some way. If they already formatted a part of the code, they might want their formatting to be used.See also https://canary.discord.com/channels/648956210850299986/1150336575675318272 and probably also similar threads where the bot formatted messages that shouldn't be changed.