Update Spring #455
Merged
Update Spring #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonlessenich
approved these changes
Dec 25, 2023
liquiddevelopmentnet
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to Spring Boot 3 (Open Source Support for Spring Boot 2.7 ended though the bot may not have kept updating minor versions anyways).
This is a major Spring and Spring Boot update. There are many breaking changes within Spring.
Aside from updating Spring, this PR contains the following changes:
temurin(Adoptium) instead ofadopt(which was AdoptOpenJDK which was replaced by Adoptium)logback-classicwas removed as a direct dependency in order for Spring to manage its versionBotConfigbeans specified inSpringConfig. One of them has been removed.@Transactionalwas removed in/qotw-adminsubcommands that either only perform read operations or only perform a single write operation.@Transactionalin commands causes issues as Spring creates CGLIB proxy classes which skip the constructor call and are not able to override DIH4JDA'sApplicationCommand#getCommandData/ApplicationCommand#setCommandDatasince these are final. As the constructor invocation is skipped for the proxy, this would cause a NPE. Removing@Transactionresults in no proxy being created.