Skip to content

Conversation

@danthe1st
Copy link
Member

I have run a SpotBugs analysis on the code and addressed a few issues:

  • closing resources with try-with-resources blocks
  • using Statements instead of PreparedStatements where no parameters where used
  • making a mutable public variable private and using a getter
  • removing unused code
  • adding queue() to some RestActions
  • removing catching of exceptions in tests if these exceptions would be issues with the test instead of issues with the actual code

Not addressed:

  • deferencing of possibly nullable expressions that shouldn't be null anyways
    • e.g. a.b() == null ? "" : a.b().c()
  • non-applicable SQL injections in code that is supposed to allow administrators to access the DB (e.g. migrations)

@danthe1st danthe1st requested a review from a team as a code owner February 24, 2024 11:31
@jasonlessenich jasonlessenich merged commit 71f31e8 into Java-Discord:main Mar 31, 2024
@danthe1st danthe1st deleted the spotbugs branch March 31, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants