Implement QoS 1 #21
Merged
Implement QoS 1 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazyrokr
requested changes
Nov 21, 2019
| boolean SUBSCRIPTION_IDENTIFIER_AVAILABLE_DEFAULT = false; | ||
|
|
||
| int PACKET_ID_FOR_QOS_0 = 0; | ||
| int PACKET_ID_MAX = 0xFFFF; |
Collaborator
There was a problem hiding this comment.
Is MAXIMUM_PACKET_ID the same ?
| return; | ||
| } | ||
|
|
||
| pendingPublishes.runInWriteLock(publishes -> { |
Collaborator
There was a problem hiding this comment.
please extract to method
| @Override | ||
| public void resendPendingPacketsAsync(@NotNull MqttClient client, int retryInterval) { | ||
| var currentTime = System.currentTimeMillis(); | ||
| var stamp = pendingPublishes.readLock(); |
Collaborator
There was a problem hiding this comment.
runInReadLock can be used
Owner
Author
There was a problem hiding this comment.
we don't have a version of this method with one object and one primitive argument
| } | ||
|
|
||
| @Override | ||
| public @NotNull Mono<Boolean> store(@NotNull String clientId, @NotNull MqttSession session, long expiryInterval) { |
crazyrokr
requested changes
Nov 23, 2019
| pendingPublishes.runInWriteLock(Collection::clear); | ||
| } | ||
|
|
||
| private void removeExpiredPackets(@NotNull Array<PendingPublish> publishes) { |
crazyrokr
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement QoS 1