Skip to content

Team1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Team1 #1

wants to merge 3 commits into from

Conversation

adunkman
Copy link
Member

@adunkman adunkman commented Feb 2, 2012

This was the proposed solution by:
@jcavena @jeremyrsellars @mez @nickmabry @joeandaverde

Challenge: create a web page that gives a QR code, and when that code is scanned, it will link a user to an activation page specific to that code.

Please comment on both the solution as a whole and the elegance / maintainability / cleanliness of various parts of the code.

@smerchek
Copy link
Contributor

smerchek commented Feb 2, 2012

I like the idea of using bitly; however, it's kind of a hindrance to need a bit.ly username and API key and having to manage those using the env variables. I do like that it provides a short url and some analytics, but the analytics are quite simple and may not even be what we want in the long run.

Perhaps this good be a better long-term solution, but right now I feel like having to get an API key would provide friction for new contributors.

@mez
Copy link
Member

mez commented Feb 2, 2012

I agree with Scott here. Lets keep it simple which will allow us to iterate
much faster.

On Thu, Feb 2, 2012 at 1:38 PM, Scott Smerchek <
reply@reply.github.com

wrote:

I like the idea of using bitly; however, it's kind of a hindrance to need
a bit.ly username and API key and having to manage those using the env
variables. I do like that it provides a short url and some analytics, but
the analytics are quite simple and may not even be what we want in the long
run.

Perhaps this good be a better long-term solution, but right now I feel
like having to get an API key would provide friction for new contributors.


Reply to this email directly or view it on GitHub:
#1 (comment)

Meseret Gebre | MeseretGebre.com

@dynajoe
Copy link
Contributor

dynajoe commented Feb 2, 2012

Simply put I agree.

Unless there's a significant use case that's solved with using bitly it's just a middleman. the analytics discussed seems simple enough to perform without third party dependencies.

@nickmabry
Copy link

I agree. It was an interesting experiment, but the Google Charts solution seems much cleaner.

@jcavena
Copy link
Member

jcavena commented Feb 2, 2012

So we kill Team1 approach and go with Team2? Is that merged into Master? What are the next steps?

@nickmabry
Copy link

Sounds good to me

@smerchek
Copy link
Contributor

smerchek commented Feb 3, 2012

If the consensus is to go with branch team2 then perhaps we should head over to that pull request and make sure it's actually what we want to pull in. There are probably some things we could do with it before next meeting to harden it some.

@dynajoe
Copy link
Contributor

dynajoe commented Feb 3, 2012

We've decided to go with a different solution. Bitly was too complicated for a simple problem.

@dynajoe dynajoe closed this Feb 3, 2012
dynajoe added a commit that referenced this pull request Feb 13, 2012
Added tests for events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants