Skip to content

Fix the wfType description #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c-dilks merged 2 commits into from
Nov 3, 2025
Merged

Fix the wfType description #928

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5799c46
Fix the wfType description
ftouchte Nov 3, 2025
8506bb1
add comment for wfType 3
ftouchte Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ public class ModeAHDC extends HipoExtractor {
private int effectiveNumberOfBins;

//Waveform types:
//0 is good,
//-1 is invalid,
//1 is saturating,
//2 has too short of a baseline,
//3 is late and only has a rising edge,
//4 is a trailing edge from a previous wf,
//5 has low ADC ("flat")
//wfType 6 ⇒ too small (nsamples <= 10)
//wfType 5 ⇒ decreasing baseline (or leadingEdgeTime fails)
//wfType 4 ⇒ bad ToT (ToT < 300)
//wfType 3 ⇒ pileUp // TO BE DONE
//wfType 2 ⇒ bad trailingEdgeTime
//wfType 1 ⇒ saturing
//wfType 0 ⇒ OK

/**
*
Expand Down