#KT-13750 fix #951
Merged
#KT-13750 fix #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| private fun specialAnnotationPropertyCases(field: PsiField): Annotations { | ||
| val javaSerializableInterface = PsiType.getTypeByName("java.io.Serializable", project, GlobalSearchScope.allScope(project)).resolve() |
There was a problem hiding this comment.
It's a minor issue, but the correct way is to use field.getResolveScope() instead of allScope here. Otherwise you may get incorrect results if the project uses multiple JDKs in different modules.
There was a problem hiding this comment.
And also JavaPsiFacade.findClass() instead of PsiType.geTypeByName(). And CommonClassNames.JAVA_IO_SERIALIZABLE instead of a hard-coded constant.
|
Looks good except for some minor notes regarding correct API usage. Please fix, and I'll merge and backport to 1.0.5. Thanks! |
|
Thanks for your contribution! |
yole
pushed a commit
that referenced
this pull request
Sep 13, 2016
(cherry picked from commit 115d63a)
dnpetrov
pushed a commit
that referenced
this pull request
Sep 22, 2016
koperagen
added a commit
that referenced
this pull request
Mar 10, 2025
[Compiler plugin] Support valueCounts Moved from Kotlin/dataframe@ec60fd4
koperagen
added a commit
that referenced
this pull request
Mar 12, 2025
[Compiler plugin] Support valueCounts Moved from Kotlin/dataframe@ec60fd4
oliviernotteghem
pushed a commit
to oliviernotteghem/kotlin
that referenced
this pull request
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/KT-13750
Notes: Should it add
@JvmStaticreally even if field matches* static final long serialVersionUIDor preform check forjava.io.Serializableis implementedNow it preforms check.
Also topic on discuss:
@JvmStaticor@JvmField