Modified SpotifyWebClient to use a single HttpClient per class lifeti… #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me. This will allow the HttpClient to properly pool connections. Reference: https://docs.microsoft.com/en-us/aspnet/web-api/overview/advanced/calling-a-web-api-from-a-net-client
JohnnyCrazy
requested changes
Sep 15, 2018
SpotifyAPI.Web/SpotifyWebClient.cs
Outdated
|
|
||
| public SpotifyWebClient() | ||
| { | ||
| HttpClientHandler clientHandler = CreateClientHandler(ProxyConfig); |
Owner
There was a problem hiding this comment.
This line won't work, since ProxyConfig will always be null. I guess adding it to the constructor with default to null would work...? It also doesnt make sense keeping it as a property, does it?
Owner
|
Thanks, nice catch :) Added one comment, I think we need to change the |
Contributor
Author
|
Happy to help. I've added the changes requested. ProxyConfig is now in the constructor of SpotifyWebClient |
Owner
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified SpotifyWebClient to use a single HttpClient per class lifetime. This will allow the HttpClient to properly pool connections, and avoids SocketException errors under load.
From the Microsoft documentation:
Source: https://docs.microsoft.com/en-us/aspnet/web-api/overview/advanced/calling-a-web-api-from-a-net-client
In depth explanation:
https://aspnetmonsters.com/2016/08/2016-08-27-httpclientwrong/