Skip to content

Conversation

@JohnstonCode
Copy link
Owner

Added the command to "scm/resourceState/context" to allow unversioned files to be ignored.

@JohnstonCode
Copy link
Owner Author

Might need to add the option to make recursive "-R" also not sure how it will behave on directories

@JohnstonCode
Copy link
Owner Author

Directories work fine. @edgardmessias what do you think about the recursive option?

@edgardmessias
Copy link
Contributor

The tortoise SVN has 4 option

  • Only the file file
  • By File extension
  • Only the file file (recursive)
  • By File extension (recursive)

@JohnstonCode
Copy link
Owner Author

Yeah saw that on tortoise.

The issue with that is how do we decide what directory we are setting the svn ignore on if we allow wildcards to be set.

@edgardmessias
Copy link
Contributor

Use like tortoise, use the directory of file.

For future, we create option to edit all properties.

@JohnstonCode
Copy link
Owner Author

That's what is currently does.

Any of the wildcard stuff can be done later if requested.

@edgardmessias
Copy link
Contributor

Ok, only need fix the naming

@codecov
Copy link

codecov bot commented Apr 2, 2018

Codecov Report

Merging #232 into master will increase coverage by 0.33%.
The diff coverage is 19.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   62.89%   63.22%   +0.33%     
==========================================
  Files          24       24              
  Lines        2339     2366      +27     
  Branches      416      418       +2     
==========================================
+ Hits         1471     1496      +25     
- Misses        864      866       +2     
  Partials        4        4
Impacted Files Coverage Δ
src/svnRepository.ts 59.44% <0%> (-2.88%) ⬇️
src/commands.ts 53.5% <25%> (-1.19%) ⬇️
src/repository.ts 72.88% <40%> (+1.97%) ⬆️
src/util.ts 85.07% <0%> (+1.49%) ⬆️
src/svn.ts 87.69% <0%> (+6.15%) ⬆️
src/decorators.ts 96.22% <0%> (+7.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1efdd2...547d683. Read the comment docs.

@JohnstonCode
Copy link
Owner Author

suggestions on the name?

@edgardmessias
Copy link
Contributor

See the review, svn.AddFileToIgnore, async addFileToIgnore

@JohnstonCode JohnstonCode merged commit 25f1f8d into master Apr 2, 2018
@JohnstonCode JohnstonCode deleted the properties branch April 2, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants