feat: enhance dependencyKeys handling to include function arguments #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates how the
dependencyKeysproperty works in the cache plugin, ensuring that both the result of the cached function and its arguments (fnArgs) are passed to thedependencyKeysfunction. This makes cache invalidation more flexible and accurate. The changes also add a corresponding test to verify this new behavior.Improvements to cache plugin API:
remapDependencyKeysand its usage so that thedependencyKeysfunction now receives both the result and the function arguments (fnArgs) as parameters, allowing for more context-aware cache key generation. (src/plugin.ts, [1] [2]README.mdto specify thatdependencyKeysreceives the result as the first argument and function arguments as the second argument.Test coverage:
dependencyKeysfunction receives the correct arguments (resultandfnArgs), and that cache keys are registered appropriately. (src/index.test.ts, src/index.test.tsR155-R186)