add more tolerated words and fix account for capitalisation #9
Merged
add more tolerated words and fix account for capitalisation #9
Conversation
JonPurvis
force-pushed
the
add-more-tolerated-words
branch
from
65a7f75 to
0c94515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few more tolerated words based on the testing in one of my applications:
I also discovered that if you use the capitalised version of a tolerated word, it still gets flagged, so this PR fixes that. E.g. usages of
stdClass. When we're looping through the tolerated words, we now also check the capitalised version.@faissaloux Just so you're aware of this change 😄