Run update_collider_parents before update_root_collider_parents to resolve ordering ambiguity on ColliderParent
#597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o resolve ordering ambiguity on `ColliderParent`
Jondolf
added
C-Bug
Member
|
#671 reworked this logic to use observers, so there shouldn't be any ambiguities or other scheduling problems anymore. Sorry for not responding to this earlier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Objective
Fixes issue with system ordering where
update_collider_parentsandupdate_root_collider_parentsboth mutably accessColliderParentat the same time.Solution
I have ordered
update_root_collider_parentsto runupdate_collider_parentsbut feel free to modify if there's a better approach.