Add error details to resource when destroy fails #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hello @chingor13 Could you please have a look at this PR ? Thank you very much |
ouranos
added a commit
to ouranos/mno-enterprise
that referenced
this pull request
Nov 27, 2017
JsonApiClient/json_api_client#275 was merged so bumping the min version and removing the patch.
enizor
pushed a commit
to enizor/mno-enterprise
that referenced
this pull request
Dec 13, 2017
JsonApiClient/json_api_client#275 was merged so bumping the min version and removing the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if destroy fails, there is no easy way to retrieve the cause.
For example
user.destroymay returns false, anduser.errorswill be empty.I think it should act the same way as
save.