Implement StableRNGs throughout tests to fix reproducibility problems in CI #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #26 +/- ##
=======================================
Coverage 86.20% 86.20%
=======================================
Files 1 1
Lines 87 87
=======================================
Hits 75 75
Misses 12 12
Continue to review full report at Codecov.
|
rikhuijzer
approved these changes
Jul 6, 2022
ablaom
added a commit
that referenced
this pull request
Jul 6, 2022
* Implement StableRNGs throughout tests to fix reproducibility problems in CI (#26) * add StableRNGs * bump compat DecisionTree = "0.11" * fix an invalid test * add rng as hyper-parameter for AdaBoostStumpClassifier * update docstring * add reproducibility test for AdaBoostStumpClassifier * srng -> stable_rng to improve readability of code * bump 0.2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we:
rngas a hyper-parameter in theAdaBoostStumpClassifiermodel