[DO NOT MERGE] Demonstration of LazyArrays extension loading issue #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #431, this PR is meant to demonstrate an issue loading the LazyArraysBlockArraysExt package extension in Julia v1.11.1 and the v1.11.2 pre-release. As a summary, I've tried running the downstream tests against a few Julia versions, here are the results: - Julia v1.11.0: All tests pass. - Julia v1.11.1: LazyArrays.jl tests fail when LazyArraysBlockArraysExt is being loaded with the error "ERROR: LoadError: ArgumentError: Package LazyArraysBlockArraysExt does not have BlockArrays in its dependencies", all others pass. - [Julia v1.11.2 pre-release](https://discourse.julialang.org/t/julia-v1-11-2-testing-period/122943): LazyArrays.jl tests fail with the same error as in Julia v1.11.1, all others pass. I tested it by setting `1.11-nightly` in the workflow. - Julia nightly: The last time I checked LazyArrays.jl tests ran properly (so the original issue plaguing Julia v1.11.1 and v1.11.2 is fixed) but failed for another independent reason. I haven't been able to reproduce this locally so this PR is the best I could do to demonstrate the issue. It seems like there is an issue in Julia v1.11.1 that is still in the v1.11.2 pre-release related to package extension loading.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
=======================================
Coverage 93.55% 93.55%
=======================================
Files 18 18
Lines 1644 1644
=======================================
Hits 1538 1538
Misses 106 106 ☔ View full report in Codecov by Sentry. |
|
Should be fixed now on v1.11.2 |
|
Rebasing on master should fix the broken test. |
|
Ok, looks like everything works now, I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #431, this PR is meant to demonstrate an issue loading the LazyArraysBlockArraysExt package extension in Julia v1.11.1 and the v1.11.2 pre-release.
As a summary, I've tried running the downstream tests against a few Julia versions, here are the results:
1.11-nightlyin the workflow.I haven't been able to reproduce this locally so this PR is the best I could do to demonstrate the issue. It seems like there is an issue in Julia v1.11.1 that is still in the v1.11.2 pre-release related to package extension loading.