-
Couldn't load subscription status.
- Fork 34
Nested block indexing #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested block indexing #482
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
=======================================
Coverage 94.52% 94.53%
=======================================
Files 19 19
Lines 1789 1810 +21
=======================================
+ Hits 1691 1711 +20
- Misses 98 99 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mtfishman I'm not sure if I've done the merging correctly or what can be done to get the tests passing.... |
|
I can look into it, maybe some of the PRs conflicted with each other. |
|
@dlfivefifty looks like it is fixed now. |
This enables nested block indexing by generalizing
BlockIndexto allow indices that aren't integers, for example:As an alternative to just generalizing
BlockIndex, maybe we could define a new type such asGenericBlockIndexand then makeBlockIndexa type alias for that with the indices restricted to integers. I don't have a strong opinion about that but this design was simpler and I don't see much advantage one way or another.Related to #49 and #446, though note that in this PR the nested block structure isn't reflected in the axes, which would be required for more systematic support of nested block structures. This PR is split off from #462.